Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The old PHP version could handle URLs directly #1

Closed
tomnomnom opened this issue Jun 4, 2016 · 3 comments · Fixed by #2
Closed

The old PHP version could handle URLs directly #1

tomnomnom opened this issue Jun 4, 2016 · 3 comments · Fixed by #2

Comments

@tomnomnom
Copy link
Owner

The new Go version should do that too. It's useful for trivial cases.
@iamthemovie
Copy link
Contributor

I have a PR for this now :)

@iamthemovie iamthemovie mentioned this issue Jun 5, 2016
Merged
@tomnomnom
Copy link
Owner Author

Awesome, thanks! I'll review it this evening :)

@tomnomnom
Copy link
Owner Author

@iamthemovie I've issued a PR onto your master branch with a couple of changes I think I'd need before accepting, have a peek: iamthemovie#1

tomnomnom pushed a commit that referenced this issue Jun 5, 2016
@iamthemovie
Merge pull request #1 from tomnomnom/fetchurl-fixes
0a7fd94 
Adds fixes for fetch URL PR
tomnomnom pushed a commit that referenced this issue Feb 22, 2017
@jagsta
Merge pull request #1 from tomnomnom/https-insecure-tweaks
b30f172 
Tweaks linter settings; updates help output in README
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added support for gronning URLs. Get requests only. Does not check co… iamthemovie/gron
2 participants
@tomnomnom @iamthemovie