Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A great start!
Here's a few suggestions/tweaks to your PR (so this is a PR for your PR - yo dawg).
go test
expects, your tests weren't actually being run ;)Table-driven tests are super useful when you want to test a bunch of inputs to a single function, and massively reduce the scope for typo or copy+paste type errors.
You definitely did the bulk of the work here though, so thanks again!
Also, nice one for using 'gron' as a verb; I think I might using 'gronning' as the term for transforming an object to discrete assignments from now on :-D
If you're happy with my changes then merge them and I'll accept your original PR.
Thanks!