Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore changelog folder in markdown linting #777

Merged
merged 1 commit into from
Nov 20, 2019

Conversation

adamconnelly
Copy link
Contributor

  • Updated the markdownlint command to ignore the changelog folder.
  • Re-added the check into the pipeline.

Fixes #775

@tomkerkhove for now I've just configured it to ignore the entire changelog folder because when I just ignored changelog/themes there were linting errors in some of the other files, and I wasn't sure if they were generated or not. If you pull down the branch you can easily try it out by changing the --ignore changelog to --ignore changelog/themes in the package.json file, and then just run npm run markdownlint to run the checks.

- Updated the markdownlint command to ignore the changelog folder.
- Re-added the check into the pipeline.
@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr777

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr777 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml  \
                         --volume C:/Promitor/runtime-config.yaml:/config/runtime.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr777

You can find a CI version of our Helm chart on hub.helm.sh

@tomkerkhove
Copy link
Owner

Awesome, now I feel like a moron for not finding that myself!

@tomkerkhove tomkerkhove merged commit 5881a55 into tomkerkhove:master Nov 20, 2019
@adamconnelly adamconnelly deleted the ignore-changelog branch November 20, 2019 17:21
@adamconnelly
Copy link
Contributor Author

Haha - no worries!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Documentation linter should not validate the Changelog template
3 participants