Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation linter should not validate the Changelog template #775

Closed
tomkerkhove opened this issue Nov 19, 2019 · 3 comments · Fixed by #777
Closed

Documentation linter should not validate the Changelog template #775

tomkerkhove opened this issue Nov 19, 2019 · 3 comments · Fixed by #777
Labels
automation documentation All issues related to documentation on how to use it, deploy it, etc enhancement Enhancements for current features

Comments

@tomkerkhove
Copy link
Owner

Documentation linter should not validate the Hugo Changelog template which is blocking all PRs, for example.

The CLI should ignore the template in changelog/themes.
@tomkerkhove tomkerkhove added automation documentation All issues related to documentation on how to use it, deploy it, etc enhancement Enhancements for current features and removed triage labels Nov 19, 2019
@tomkerkhove
Copy link
Owner Author

Are you up for this @adamconnelly ?

@tomkerkhove tomkerkhove mentioned this issue Nov 19, 2019
Merged
@adamconnelly
Copy link
Contributor

@tomkerkhove I'm happy to - I'm just pretty busy at work right now so I can't make a guarantee about how quickly I'll be able to take a look. I think it's just a case of adding an extra parameter to the command that runs to tell it to ignore a folder, so in theory it should be fairly simple to fix.

@tomkerkhove
Copy link
Owner Author

I've had a look but couldn't find it so would be good to have you jump in if possible!

It's mitigated for now so no rush and take your time, make sure you relax as well!

@adamconnelly adamconnelly mentioned this issue Nov 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
automation documentation All issues related to documentation on how to use it, deploy it, etc enhancement Enhancements for current features
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore changelog folder in markdown linting adamconnelly/promitor
2 participants
@adamconnelly @tomkerkhove