-
-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
helm: add resources options in the deployment #617
helm: add resources options in the deployment #617
Conversation
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr617 Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-agent-scraper-pr617 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env-file C:/Promitor/az-mon-auth.creds \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr617 You can find a CI version of our Helm chart on hub.helm.sh |
Thank you for your PR @mathieuherbert! Feel free to provide default resource limitations as we're working towards v1.0. Don't have a concrete proposal on limitations now but can still tweak them afterward. |
Relates to #618 |
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr617 Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-agent-scraper-pr617 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env-file C:/Promitor/az-mon-auth.creds \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr617 You can find a CI version of our Helm chart on hub.helm.sh |
Docker image for this PR was built and is available on Docker Hub. You can pull it locally via the CLI: docker pull tomkerkhove/promitor-agent-scraper-ci:pr617 Want to verify the new version? Run it locally: docker run -d -p 8999:80 --name promitor-agent-scraper-pr617 \
--env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
--env-file C:/Promitor/az-mon-auth.creds \
--volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
tomkerkhove/promitor-agent-scraper-ci:pr617 You can find a CI version of our Helm chart on hub.helm.sh |
Thank you for your contribution @mathieuherbert ! |
Currently, the helm chart does not have any resources parameter for the deployment.
Proposed Changes
resources
parameter in the helm chart