Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

helm: add resources options in the deployment #617

Merged
merged 3 commits into from
Jul 19, 2019

Conversation

mathieuherbert
Copy link
Contributor

Currently, the helm chart does not have any resources parameter for the deployment.

Proposed Changes

  • add resources parameter in the helm chart
  • keep it to empty for the compatibility

@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr617

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr617 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr617

You can find a CI version of our Helm chart on hub.helm.sh

@tomkerkhove tomkerkhove self-assigned this Jul 19, 2019
@tomkerkhove tomkerkhove added helm All issues related to Helm kubernetes All issues related to Kubernetes stability All issues related to stability labels Jul 19, 2019
@tomkerkhove tomkerkhove added this to the v1.0.0 milestone Jul 19, 2019
@tomkerkhove
Copy link
Owner

Thank you for your PR @mathieuherbert! Feel free to provide default resource limitations as we're working towards v1.0.

Don't have a concrete proposal on limitations now but can still tweak them afterward.

@tomkerkhove
Copy link
Owner

Relates to #618

@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr617

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr617 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr617

You can find a CI version of our Helm chart on hub.helm.sh

@promitor-bot
Copy link

Docker image for this PR was built and is available on Docker Hub.

You can pull it locally via the CLI:

docker pull tomkerkhove/promitor-agent-scraper-ci:pr617

Want to verify the new version? Run it locally:

docker run -d -p 8999:80 --name promitor-agent-scraper-pr617 \
                         --env PROMITOR_AUTH_APPID='<azure-ad-app-id>' \
                         --env-file C:/Promitor/az-mon-auth.creds \
                         --volume C:/Promitor/metrics-declaration.yaml:/config/metrics-declaration.yaml \
                         tomkerkhove/promitor-agent-scraper-ci:pr617

You can find a CI version of our Helm chart on hub.helm.sh

@tomkerkhove
Copy link
Owner

Thank you for your contribution @mathieuherbert !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
helm All issues related to Helm kubernetes All issues related to Kubernetes stability All issues related to stability
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants