Skip to content

Commit

Permalink
helm: add resources options in the deployment (#617)
Browse files Browse the repository at this point in the history
  • Loading branch information
mathieuherbert authored and tomkerkhove committed Jul 19, 2019
1 parent 6e25e59 commit a3152c9
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 0 deletions.
1 change: 1 addition & 0 deletions charts/promitor-agent-scraper/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ The following table lists the configurable parameters of the Promitor chart and
| `metricDefaults.aggregation.interval` | Default interval which defines over what period measurements of a metric should be aggregated | `00:05:00` |
| `metricDefaults.scraping.schedule` | Cron expression that controls the fequency in which all the configured metrics will be scraped from Azure Monitor | `*/5 * * * *` |
| `metrics` | List of metrics to scrape configured following the [metric declaration docs](https://promitor.io/configuration/metrics/) | |
| `resources` | Pod resource requests & limits | `{}` |
| `secrets.createSecret` | Indication if you want to bring your own secret level of logging | `true` |
| `secrets.appIdSecret` | Name of the secret for Azure AD identity id | `azure-app-id` |
| `secrets.appKeySecret` | Name of the secret for Azure AD identity secret | `azure-app-key` |
Expand Down
2 changes: 2 additions & 0 deletions charts/promitor-agent-scraper/templates/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ spec:
- name: PROMITOR_LOGGING_MINIMUMLEVEL
value: {{ .Values.logging.minimalLogLevel }}
{{- end }}
resources:
{{ toYaml .Values.resources | indent 12 }}
volumeMounts:
- name: config-volume-{{ template "promitor-agent-scraper.fullname" . }}
mountPath: /config/
Expand Down
8 changes: 8 additions & 0 deletions charts/promitor-agent-scraper/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -62,3 +62,11 @@ service:
targetPort: 88
labelType: infrastructure
selectorType: runtime

resources: {}
# limits:
# cpu: 100m
# memory: 128Mi
# requests:
# cpu: 100m
# memory: 128Mi

0 comments on commit a3152c9

Please sign in to comment.