Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How should the scraping approach unsupported aggregation intervals #288

Closed
tomkerkhove opened this issue Feb 3, 2019 · 2 comments
Closed
Labels
discussion integration:azure-monitor All issues related to Azure Monitor integration

Comments

@tomkerkhove
Copy link
Owner

tomkerkhove commented Feb 3, 2019

With #256 & #257 you will be able to define the aggregation interval which should be used to get the value for a metric.

I'm curious how you would expect the scraper to handle unsupported intervals.

Options are :

  1. Block in validation
  2. Automatically use closest supported interval and write warning message
  3. Automatically determine closest supported interval at runtime and change configuration to this instead and write warning message

Currently 2 is implemented.

@tomkerkhove tomkerkhove added integration:azure-monitor All issues related to Azure Monitor integration discussion labels Feb 3, 2019
@tomkerkhove
Copy link
Owner Author

We're going forward with the fail fast approach and block it in the validation.

@tomkerkhove
Copy link
Owner Author

Agreed to use option 1 going forward, will be done via #463, #464 & #465

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion integration:azure-monitor All issues related to Azure Monitor integration
Projects
None yet
Development

No branches or pull requests

1 participant