Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide capability to configure the metric aggregation interval per metric #256

Closed
8 tasks done
tomkerkhove opened this issue Dec 14, 2018 · 2 comments
Closed
8 tasks done
Labels
configuration All issues related to configuration feature All issues that are new features integration:azure-monitor All issues related to Azure Monitor integration specs-required All issues where the specifications are still being defined and implementation should be halted
Milestone

Comments

@tomkerkhove
Copy link
Owner

tomkerkhove commented Dec 14, 2018

Metrics do not always need to be scraped with the same metrics aggregation.

We should provide the capability to configure the metric aggregation interval per metric.

Checklist

In order to achieve this we will:

  • Introduce aggregation as part of azureMetricConfiguration which contains all aggregation related information
  • Configure the aggregation interval via azureMetricConfiguration.aggregation.interval
  • Move aggregation type ot the aggregation interval via azureMetricConfiguration.aggregation.type
  • Use configured aggregation period when scraping Azure Monitor
  • Update documentation on how to configure this and the impact of the size
  • Provide clear guidance on breaking change in documentation (depends on Introduce a change log on promitor.io #255)

What needs to be defined

  • How we will configure our aggragation interval - Do we stick with cron or do we use a different approach?
  • Do we enforce intervals higher than 5 minutes and validate it at startup, or is it the responsibility of the consumer (assuming we make this clear in docs)

Metrics Specification

azureMetadata:
  tenantId: xxxxxxxx-xxxx-xxxx-xxxx-xxxxxxxxxxxx
  subscriptionId: yyyyyyyy-yyyy-yyyy-yyyy-yyyyyyyyyyyy
  resourceGroupName: promitor
metrics: 
  - name: demo_queue_size
    description: "Amount of active messages of the 'myqueue' queue"
    resourceType: ServiceBusQueue
    namespace: promitor-messaging
    queueName: orders
    azureMetricConfiguration:
      metricName: ActiveMessages
      aggregation:
        type: Total
        interval: <interval>

Other

Closes #60 and #198

@tomkerkhove tomkerkhove added integration:azure-monitor All issues related to Azure Monitor integration feature All issues that are new features configuration All issues related to configuration specs-required All issues where the specifications are still being defined and implementation should be halted labels Dec 14, 2018
@tomkerkhove tomkerkhove added this to the v1.0.0 milestone Dec 14, 2018
@tomkerkhove
Copy link
Owner Author

Will pick this up next week probably

tomkerkhove added a commit that referenced this issue Feb 6, 2019
Provide capability to configure aggregation interval via metric defaults or on a per-metric basis

Relates to #256 & #257
@tomkerkhove
Copy link
Owner Author

Docs will be handled via #293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
configuration All issues related to configuration feature All issues that are new features integration:azure-monitor All issues related to Azure Monitor integration specs-required All issues where the specifications are still being defined and implementation should be halted
Projects
None yet
Development

No branches or pull requests

1 participant