Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce new validation step for verifying configured Azure Monitor metrics #464

Open
4 tasks
tomkerkhove opened this issue Mar 27, 2019 · 1 comment
Open
4 tasks
Labels
agents:scraper All issues related to the scraping agent configuration All issues related to configuration enhancement Enhancements for current features Hacktoberfest All issues available for contribution during Hacktoberfest help-wanted All issues where people can contribute to the project runtime All issues related to our runtime

Comments

@tomkerkhove
Copy link
Owner

Introduce new validation step for verifying configured Azure Monitor metrics at startup.

For every single configured metric it should:

  • Verify that it has access to query it
  • Verify that the configured metric name exists
  • Verify that the configured aggregation interval exactly matches with what is supported
  • Verify that the configured dimension is supported if configured

Every failure of the above should have a clear description that it failed and why it failed. No exceptions should be bubbled up as it will only be noise in the telemetry.

Next to unit tests we'll need to add integration tests for these scenarios which should also be added to the CI, although that will be done via #463

@tomkerkhove tomkerkhove added enhancement Enhancements for current features configuration All issues related to configuration runtime All issues related to our runtime labels Mar 27, 2019
@tomkerkhove tomkerkhove modified the milestones: v1.0.0, v1.1.0 Mar 27, 2019
@tomkerkhove tomkerkhove modified the milestones: v1.1.0, v1.2.0 Oct 21, 2019
@tomkerkhove tomkerkhove modified the milestones: v1.2.0, v1.3.0, v1.4.0, v1.5.0 Jan 6, 2020
@tomkerkhove tomkerkhove modified the milestones: v1.5.0, v1.6.0 Jan 30, 2020
@tomkerkhove tomkerkhove added the help-wanted All issues where people can contribute to the project label Mar 23, 2020
@tomkerkhove tomkerkhove removed this from the v1.6.0 milestone Mar 23, 2020
@tomkerkhove tomkerkhove added the agents:scraper All issues related to the scraping agent label Apr 21, 2020
@tomkerkhove tomkerkhove moved this to Proposed in Promitor Roadmap May 17, 2022
@tomkerkhove
Copy link
Owner Author

This is becoming more and more important, prioritizing.

@tomkerkhove tomkerkhove added the Hacktoberfest All issues available for contribution during Hacktoberfest label Sep 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agents:scraper All issues related to the scraping agent configuration All issues related to configuration enhancement Enhancements for current features Hacktoberfest All issues available for contribution during Hacktoberfest help-wanted All issues where people can contribute to the project runtime All issues related to our runtime
Projects
Status: Proposed
Development

No branches or pull requests

1 participant