Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: path fixes for files/file, retryfunc for directory deletion #113

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

manicminer
Copy link
Collaborator

@manicminer manicminer commented Mar 26, 2024

  • Fix a bug where a blank path can result in double slashes in the resource ID string, which the API doesn't tolerate
  • Fix various method bugs where the path is erroneously prefixed with an additional slash
  • Add a retry function when deleting directories (sometimes files within can linger after deletion)

Related: hashicorp/terraform-provider-azurerm#25353

Copy link
Collaborator

@catriona-m catriona-m left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@manicminer manicminer merged commit a1ba466 into main Mar 26, 2024
1 check passed
@manicminer manicminer deleted the bugfix/double-slash-in-path branch March 26, 2024 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants