Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add challenge 49 #763

Merged
merged 4 commits into from
Apr 22, 2024
Merged

Conversation

alcaidio
Copy link
Contributor

@alcaidio alcaidio commented Apr 12, 2024

Here's another challenge ready for the week after ^^ for rxjs this time.

(Need to merge #759 before this one)

Looking forward to your feedback.

@alcaidio alcaidio force-pushed the feat/challenge-49 branch from bbe524c to fcbab22 Compare April 12, 2024 00:54
@alcaidio alcaidio force-pushed the feat/challenge-49 branch from fcbab22 to 2d6dcf3 Compare April 12, 2024 11:24
@tomalaforge tomalaforge added contributor highly contributing to the project challenge-creation contributing on the creation of a new challenge and removed contributor highly contributing to the project labels Apr 12, 2024
Copy link
Contributor

@jdegand jdegand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if @tomalaforge wants to focus much on RxJS much in the future, as RxJS becoming optional seems to be inevitable, but this is a nice callback to past RxJS challenges I've seen.

This repo is a great resource for RxJS challenges.

The deployment failed because the authors json file is missing?

apps/rxjs/hold-to-save-btn/README.md Outdated Show resolved Hide resolved
@alcaidio
Copy link
Contributor Author

The deployment failed because the authors json file is missing?

Yes @jdegand it will be fixed after #759 has merged

@tomalaforge
Copy link
Owner

This is a super nice challenge. I love it 😍
@jdegand you are right and not right 😅 Indeed rxjs will be less and less present inside Angular. The goal of the team is to make it optional. (But this is not in a near future), and rxjs is still very powerful and can let you do things in a nice way that other lib cannot.
And moreover, there are always old angular projects that are far from using signals.
And lastly, rxjs is great for async events, which are not signal. So rxjs is still and will still be a great tool to have in your toolkit. So keep producing rxjs challenges 🔥

And when I have more time, I will try to start with some signal challenges.

@jdegand
Copy link
Contributor

jdegand commented Apr 16, 2024

Actually, I looked into this and Angular is in a weird place. Most of the community is not adopting signals or even standalone components yet. See Academind state of Angular 2024.

Async/await can be used in Angular (See this YouTube video) and its usage should only grow after zoneless hits.

@tomalaforge
Copy link
Owner

Actually, I looked into this and Angular is in a weird place. Most of the community is not adopting signals or even standalone components yet. See Academind state of Angular 2024.

Async/await can be used in Angular (See this YouTube video) and its usage should only grow after zoneless hits.

Yes I know, and the weird place is not over yet. I think the time angular gets more stable will take more than a year. We will see what's the future holds. but for now, let's do challenges on rxjs. But I agree with you, if rxjs become optional, it will become less and less used. Because people will not bother learn it. It's too hard to understand.
async/await is simpler because it can be sequential.


Here the prototype made by Lucie:

![prototype gif](../../../../../../docs/src/assets/rxjs/49/prototype.gif)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The build fail, because the path is wrong.

try npm run doc:dev before pushing to test that the documentation site is launching correctly

@tomalaforge
Copy link
Owner

@alcaidio Can you rebase it and correct the path of the image so I can merge it tomorrow ?

@tomalaforge tomalaforge merged commit ccf967d into tomalaforge:main Apr 22, 2024
2 checks passed
@alcaidio
Copy link
Contributor Author

@alcaidio Can you rebase it and correct the path of the image so I can merge it tomorrow ?

Sorry @tomalaforge I wasn't available, but I see you've merged thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
challenge-creation contributing on the creation of a new challenge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants