Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create challenge 48 without solution #759

Merged
merged 7 commits into from
Apr 16, 2024

Conversation

alcaidio
Copy link
Contributor

@alcaidio alcaidio commented Apr 10, 2024

Here's a challenge I'm proposing, I hope you enjoy it.

How do I do for the solution I add a commit to this PR or I'll make a PR within 1 week?

Thanks for your work @tomalaforge :)

@tomalaforge
Copy link
Owner

Very good challenge, thanks a lot for posting it 🙏

You should put it under the form folder not under angular folder.

About your solution. you can create a PR one week after the challenge is released. I often release challenges at the beginning of a new week. So if everything is ready, we can merge the challenge for monday or tuesday of next week and you can submit your solution the week after.

Thanks again, very good job

@alcaidio
Copy link
Contributor Author

Thanks :)

You should put it under the form folder not under angular folder.

Yes i know but the schematic to generate the project dont have the option in the select, i'll create the issue.

Any idea to move the project in form folder easily ?

@tomalaforge
Copy link
Owner

You are right about the schematic, I forgot to add the form folder 😅 I will fix that in a new PR.

But for now, you need to do it manually. That's not a big job. Just move your folder to form and then you have to update all the links in all landing page. And you should be good to go

@tomalaforge
Copy link
Owner

Seems good to me.
And perfect for the youtube link.
I will merge it on Monday and post it on twitter on monday evening

Good job. thanks

@svenson95
Copy link
Contributor

@alcaidio really cool challenge, i like the structure of the article with context and user story. I'll do this challenge and give feedback. In my experience, it's good if someone tries out the challenge before it finally goes live so that you can make adjustments or improvements.

I already have a suggestion for improvement. The title is a bit long, thus the challenge link in the sidebar requires two lines. Maybe a title like "Avoid losing form data", "Avoid losing data on navigation" or something like that would be better.

@jdegand
Copy link
Contributor

jdegand commented Apr 11, 2024

I already have a suggestion for improvement. The title is a bit long, thus the challenge link in the sidebar requires two lines. Maybe a title like "Avoid losing form data", "Avoid losing data on navigation" or something like that would be better.

I suggest you name the challenge Dialog Alert since that is the name used in the files.

@alcaidio
Copy link
Contributor Author

I already have a suggestion for improvement. The title is a bit long, thus the challenge link in the sidebar requires two lines. Maybe a title like "Avoid losing form data", "Avoid losing data on navigation" or something like that would be better.

Thanks for you feedback @svenson95 :) Yes, "Avoid losing form data" will be great !

@alcaidio alcaidio mentioned this pull request Apr 12, 2024
@tomalaforge tomalaforge added contributor highly contributing to the project and removed contributor highly contributing to the project labels Apr 12, 2024
@tomalaforge tomalaforge merged commit 3133274 into tomalaforge:main Apr 16, 2024
1 check passed
@tomalaforge
Copy link
Owner

@all-contributors add @alcaidio for doc

Copy link
Contributor

@tomalaforge

I've put up a pull request to add @alcaidio! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
challenge-creation contributing on the creation of a new challenge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants