-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: create challenge 48 without solution #759
Conversation
42517ec
to
f7fdb99
Compare
f7fdb99
to
f994028
Compare
f994028
to
c486c77
Compare
fcde107
to
610a56f
Compare
610a56f
to
5bc25df
Compare
docs/src/content/docs/challenges/angular/48-dialog-alert-form.md
Outdated
Show resolved
Hide resolved
docs/src/content/docs/challenges/angular/48-dialog-alert-form.md
Outdated
Show resolved
Hide resolved
docs/src/content/docs/challenges/angular/48-dialog-alert-form.md
Outdated
Show resolved
Hide resolved
Very good challenge, thanks a lot for posting it 🙏 You should put it under the form folder not under angular folder. About your solution. you can create a PR one week after the challenge is released. I often release challenges at the beginning of a new week. So if everything is ready, we can merge the challenge for monday or tuesday of next week and you can submit your solution the week after. Thanks again, very good job |
Thanks :)
Yes i know but the schematic to generate the project dont have the option in the select, i'll create the issue. Any idea to move the project in form folder easily ? |
c39e42c
to
013fb00
Compare
docs/src/content/docs/challenges/angular/48-dialog-alert-form.md
Outdated
Show resolved
Hide resolved
docs/src/content/docs/challenges/angular/48-dialog-alert-form.md
Outdated
Show resolved
Hide resolved
You are right about the schematic, I forgot to add the form folder 😅 I will fix that in a new PR. But for now, you need to do it manually. That's not a big job. Just move your folder to form and then you have to update all the links in all landing page. And you should be good to go |
06d7e4a
to
11fac7e
Compare
Seems good to me. Good job. thanks |
@alcaidio really cool challenge, i like the structure of the article with context and user story. I'll do this challenge and give feedback. In my experience, it's good if someone tries out the challenge before it finally goes live so that you can make adjustments or improvements. I already have a suggestion for improvement. The title is a bit long, thus the challenge link in the sidebar requires two lines. Maybe a title like "Avoid losing form data", "Avoid losing data on navigation" or something like that would be better. |
I suggest you name the challenge |
Thanks for you feedback @svenson95 :) Yes, "Avoid losing form data" will be great ! |
0adc0f6
to
230de0c
Compare
@all-contributors add @alcaidio for doc |
I've put up a pull request to add @alcaidio! 🎉 |
Here's a challenge I'm proposing, I hope you enjoy it.
How do I do for the solution I add a commit to this PR or I'll make a PR within 1 week?
Thanks for your work @tomalaforge :)