-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rmfakecloud-proxy: Set status check timeout to 5s #561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Running `rmfakecloudctl status` with an unreachable server set as upstream would previously hang indefinitely. This PR sets the wget timeout to 5 seconds with no retry. It also changes the `status` command output to give feedback to the user before attempting to reach the server. Fixes #536.
LinusCDE
approved these changes
Mar 3, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All changes work great!
Thanks for the review! |
matteodelabre
added a commit
that referenced
this pull request
Apr 17, 2022
This stable merge brings support for reMarkable OS releases 2.12.2 and 2.12.3. New packages ------------ * `toltec-base` - 1.0-1 (#532) - Metapackage used for specifying the default-installed packages * `open-remarkable-shutdown` - 1.0-1 (#532) - Overrides the `remarkable-shutdown` and `remarkable-reboot` default configurations to use `remarkable-splash` instead of the stock utility - Fixes custom poweroff/reboot screens not working on rM1 - Will be installed by default on rM1 Updated packages ---------------- * `ddvk-hacks` - 32.02-1 (#579, #584) - Add support for 2.12.2 - Add support for 2.12.3 * `display` - 1:0.0.16-1 (#578, #585) - Add support for rM2 2.12.2 - Add support for rM2 2.12.3 * `folly` - 0.0.1-2 (#564) - (Recipe improvements) * `keywriter` - 0.2~20-gddc9e73-1 (#565) - Reduce font size in edit mode - Set default buffer orientation to portrait - Rotate the buffer using Ctrl-Left/Ctrl-Right in view mode - Add Ctrl-Q shortcut to quit the app - Restore cursor position when switching between modes * `koreader` - 2022.03.1-1 (#562, #574, #575) - Don't use KOReader suspend/screensaver/autosuspend when Oxide is running - [2022.03.1 release notes](https://github.com/koreader/koreader/releases/tag/v2022.03.1) - [2022.03 release notes](https://github.com/koreader/koreader/releases/tag/v2022.03) - [2022.02 release notes](https://github.com/koreader/koreader/releases/tag/v2022.02) * `toltec-bootstrap` - 0.2.2-1 (#532) - Add transient dependency on `toltec-base` for existing installs * `xochitl` - 0.0.0-13 (#532, #567) - Make sure xochitl starts after/stops before the launcher - Force creating/removing the launcher.service alias when needed - Fix spurious warning when no pre-scripts are available for xochitl (e.g., on rM1) - Add transient dependency on `toltec-base` for existing installs * `rmfakecloud-proxy` - 0.0.3-3 (#561) - Add timeout to `status` command in case the upstream server is unreachable - Show feedback to the user while the upstream server is being pinged * `harmony` - 0.2.0-1 (#572) - Add layer support - Fix segfaults when showing empty load/import dialogs - Exporting canvas to PNG supports grays instead of dithering - RLE snapshots for history (less memory usage) - Support SYN_DROPPED in wacom events * `remux` - 0.2.2-1 - RLE snapshots use less memory - Save BPP when screenshotting current app - Filter palm events from gestures (less false positives) - Support SYN_DROPPED in wacom events
matteodelabre
added a commit
that referenced
this pull request
Apr 23, 2022
This stable merge brings support for reMarkable OS releases 2.12.2 and 2.12.3. New packages ------------ * `toltec-base` - 1.0-1 (#532) - Metapackage used for specifying the default-installed packages * `open-remarkable-shutdown` - 1.0-1 (#532) - Overrides the `remarkable-shutdown` and `remarkable-reboot` default configurations to use `remarkable-splash` instead of the stock utility - Fixes custom poweroff/reboot screens not working on rM1 - Will be installed by default on rM1 Updated packages ---------------- * `ddvk-hacks` - 32.02-1 (#579, #584) - Add support for 2.12.2 - Add support for 2.12.3 * `display` - 1:0.0.16-1 (#578, #585) - Add support for rM2 2.12.2 - Add support for rM2 2.12.3 * `keywriter` - 0.2~20-gddc9e73-1 (#565) - Reduce font size in edit mode - Set default buffer orientation to portrait - Rotate the buffer using Ctrl-Left/Ctrl-Right in view mode - Add Ctrl-Q shortcut to quit the app - Restore cursor position when switching between modes * `koreader` - 2022.03.1-1 (#562, #574, #575) - Don't use KOReader suspend/screensaver/autosuspend when Oxide is running - [2022.03.1 release notes](https://github.com/koreader/koreader/releases/tag/v2022.03.1) - [2022.03 release notes](https://github.com/koreader/koreader/releases/tag/v2022.03) - [2022.02 release notes](https://github.com/koreader/koreader/releases/tag/v2022.02) * `toltec-bootstrap` - 0.2.2-1 (#532) - Add transient dependency on `toltec-base` for existing installs * `xochitl` - 0.0.0-13 (#532, #567) - Make sure xochitl starts after/stops before the launcher - Force creating/removing the launcher.service alias when needed - Fix spurious warning when no pre-scripts are available for xochitl (e.g., on rM1) - Add transient dependency on `toltec-base` for existing installs * `rmfakecloud-proxy` - 0.0.3-3 (#561) - Add timeout to `status` command in case the upstream server is unreachable - Show feedback to the user while the upstream server is being pinged * `harmony` - 0.2.0-1 (#572) - Add layer support - Fix segfaults when showing empty load/import dialogs - Exporting canvas to PNG supports grays instead of dithering - RLE snapshots for history (less memory usage) - Support SYN_DROPPED in wacom events * `remux` - 0.2.2-1 (#572) - RLE snapshots use less memory - Save BPP when screenshotting current app - Filter palm events from gestures (less false positives) - Support SYN_DROPPED in wacom events
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
rmfakecloudctl status
with an unreachable server set as upstream would previously hang indefinitely. This PR sets the wget timeout to 5 seconds with no retry. It also changes thestatus
command output to give feedback to the user before attempting to reach the server.Fixes #536.