Fix remarkable-shutdown calls and add toltec-base package

[Eeems]

On the rM1 remarkable-shutdown and remarkable-reboot don't actually display anything anymore on my system. In order to resolve this, and ensure that shutdown and reboot images are properly displayed, I've replaced the calls with remarkable-splash.

This will have to be tested on both the rM1 and rM2.

[matteodelabre]

I can confirm I see the same issue on rM1, version 2.11.0.442. However remarkable-shutdown is working fine on rM2 (same version), so I would say that this is likely just an oversight from rM. I’m a bit hesitant to include such a fix in Toltec. Perhaps a better route would be to notify the rM devs of this and get this fixed?

[Eeems]

I can confirm I see the same issue on rM1, version 2.11.0.442. However remarkable-shutdown is working fine on rM2 (same version), so I would say that this is likely just an oversight from rM. I’m a bit hesitant to include such a fix in Toltec. Perhaps a better route would be to notify the rM devs of this and get this fixed?

Next time we see them on we can try to let them know I guess. That said, it's broken right now, so we might as well fix it for our users in a way that works across OS versions. This also gives us options if they ever decide to move the shutdown/reboot image display logic inside xochitl.

[matteodelabre]

You make a good point. Are you sure this belongs to the xochitl package though? This will make using remarkable-splash mandatory for most users. Would it make more sense to add this to the remarkable-splash package itself? Or in a new package?

[Eeems]

You make a good point. Are you sure this belongs to the xochitl package though? This will make using remarkable-splash mandatory for most users. Would it make more sense to add this to the remarkable-splash package itself? Or in a new package?

Good point. Perhaps a separate fix package similar to the wifi suspend fix?

[Eeems]

@matteodelabre poke?

[raisjn]

a new package sounds good, let me know if you need review

[matteodelabre]

On version 2.12 remarkable-shutdown is still a no-op, so it does look like a deliberate decision from rM.

[Eeems]

Okay, I've updated it to use its own package. I've also created a meta package so that we can make it easier to specify packages that need to be installed on the rM1 or rM2. I've added it as a dependency of the xochitl package so that as people upgrade they'll also get it. Eventually we can drop that dependency. I also tweaked toltec-bootstrap to handle installing it.

[matteodelabre]

Should we also add wget-ssl to the set of base packages?

[Eeems]

Should we also add wget-ssl to the set of base packages?

Perhaps, although we'd also need to change how bootstrap handles its additional dependencies:

[[ ! -d /opt/etc/ssl/certs ]] && additional_packages+=(ca-certificates)
[[ ! -f /opt/bin/wget ]] && additional_packages+=(wget-ssl)

[matteodelabre]

Perhaps, although we'd also need to change how bootstrap handles its additional dependencies

Good point, let’s not complicate this PR further then, we can handle this separately.

[matteodelabre]

The changes look good, we’ll only need some testing to validate everything works as expected.

[matteodelabre]

There seems to be a bug from our build system: the open-remarkable-shutdown dependency gets added to the rM2 version of the base package.

[Eeems]

We should probably fix that before merging.

[matteodelabre]

Looks good to me!

Tested on rM1 and rM2: on upgrade, toltec-base is automatically installed (on both devices). rM2 picks up rm2-suspend-fix and rM1 picks up open-remarkable-shutdown. On rM1, reboot and shutdown screens are shown properly after shutdown now and reboot.

[matteodelabre]

On rM1, I also tested it with Oxide, making sure the reboot/shutdown images are shown after Oxide quits.