-
Notifications
You must be signed in to change notification settings - Fork 726
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove experimental parts of tracing-error #547
Merged
Merged
Commits on Jan 28, 2020
-
readme: quick typo fix (tokio-rs#546)
Fixes a small typo that inverts the intended meaning.
Configuration menu - View commit details
-
Copy full SHA for 9b07cb3 - Browse repository at this point
Copy the full SHA 9b07cb3View commit details -
subscriber: fix
Layered
layers not downcasting to themselves (tokio……-rs#549) Currently, a `Layered` struct's implementations of `Subscriber` and `Layer` will successfully downcast to either the the `Layer` type or the inner type, but *not* to `Layered<Layer, Inner>`. This means that when a `Layer` tries to downcast the wrapped subscriber to a known type, and it is a `Layered` (so, any time more than one layer wraps a subscriber and a layer other than the first one tries to downcast to the inner type it wraps), the downcast will fail incorrectly. This commit fixes the issue by checking if the downcast target `TypeId` equals the `Layered` type's `TypeId`, _before_ trying to downcast to the layer itself or to the inner type. Signed-off-by: Eliza Weisman <[email protected]>
Configuration menu - View commit details
-
Copy full SHA for c98c69b - Browse repository at this point
Copy the full SHA c98c69bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20ede80 - Browse repository at this point
Copy the full SHA 20ede80View commit details -
Configuration menu - View commit details
-
Copy full SHA for fbb1b50 - Browse repository at this point
Copy the full SHA fbb1b50View commit details -
Configuration menu - View commit details
-
Copy full SHA for 564d5b2 - Browse repository at this point
Copy the full SHA 564d5b2View commit details -
Configuration menu - View commit details
-
Copy full SHA for d10beae - Browse repository at this point
Copy the full SHA d10beaeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9b33c73 - Browse repository at this point
Copy the full SHA 9b33c73View commit details -
Configuration menu - View commit details
-
Copy full SHA for b15a116 - Browse repository at this point
Copy the full SHA b15a116View commit details -
Configuration menu - View commit details
-
Copy full SHA for 495fd84 - Browse repository at this point
Copy the full SHA 495fd84View commit details -
Configuration menu - View commit details
-
Copy full SHA for 455c524 - Browse repository at this point
Copy the full SHA 455c524View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3989f24 - Browse repository at this point
Copy the full SHA 3989f24View commit details
Commits on Jan 29, 2020
-
Configuration menu - View commit details
-
Copy full SHA for fd49982 - Browse repository at this point
Copy the full SHA fd49982View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.