Remove experimental parts of tracing-error #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hawkw
reviewed
Jan 27, 2020
yaahc
force-pushed
the
eliza/error-sketch
branch
from
cca93c1
to
493cc30
Compare
Fixes a small typo that inverts the intended meaning.
…-rs#549) Currently, a `Layered` struct's implementations of `Subscriber` and `Layer` will successfully downcast to either the the `Layer` type or the inner type, but *not* to `Layered<Layer, Inner>`. This means that when a `Layer` tries to downcast the wrapped subscriber to a known type, and it is a `Layered` (so, any time more than one layer wraps a subscriber and a layer other than the first one tries to downcast to the inner type it wraps), the downcast will fail incorrectly. This commit fixes the issue by checking if the downcast target `TypeId` equals the `Layered` type's `TypeId`, _before_ trying to downcast to the layer itself or to the inner type. Signed-off-by: Eliza Weisman <[email protected]>
yaahc
force-pushed
the
eliza/error-sketch
branch
from
493cc30
to
495fd84
Compare
hawkw
approved these changes
Jan 28, 2020
There was a problem hiding this comment.
This looks great! I commented on a couple minor nits.
I think once this merges, we just need to add some docs (& maybe a few tests), and we can probably release an 0.0.1 (or even 0.1) of a tracing-error crate with just the SpanTrace type. I'd like to eventually include a strategy for attaching SpanTraces to std::error::Errors, but if you'd rather experiment with that out of tree, I can deal with that :)
|
@yaahc it looks like clippy is upset about an unused import: https://github.com/tokio-rs/tracing/pull/547/checks?check_run_id=413925052#step:4:566 would you mind fixing this? |
|
cool, merged it |
hawkw
added a commit
that referenced
this pull request
Feb 1, 2020
* readme: quick typo fix (#546) Fixes a small typo that inverts the intended meaning. * Remove experimental parts of tracing-error * Rename span backtrace to SpanTrace * Swap bodies of Display and Debug * Make try-like macro internal only * Break eliza's code some more * Broken presents for eliza * subscriber: fix `Layered` layers not downcasting to themselves (#549) Currently, a `Layered` struct's implementations of `Subscriber` and `Layer` will successfully downcast to either the the `Layer` type or the inner type, but *not* to `Layered<Layer, Inner>`. This means that when a `Layer` tries to downcast the wrapped subscriber to a known type, and it is a `Layered` (so, any time more than one layer wraps a subscriber and a layer other than the first one tries to downcast to the inner type it wraps), the downcast will fail incorrectly. This commit fixes the issue by checking if the downcast target `TypeId` equals the `Layered` type's `TypeId`, _before_ trying to downcast to the layer itself or to the inner type. Signed-off-by: Eliza Weisman <[email protected]> * Fix unused result * Fix last clippy warn * Minor tweeks based on eliza's suggestions * all hail our lord and savior clippy Co-authored-by: Khionu Sybiern <[email protected]> Co-authored-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this pull request
Feb 2, 2020
* readme: quick typo fix (#546) Fixes a small typo that inverts the intended meaning. * Remove experimental parts of tracing-error * Rename span backtrace to SpanTrace * Swap bodies of Display and Debug * Make try-like macro internal only * Break eliza's code some more * Broken presents for eliza * subscriber: fix `Layered` layers not downcasting to themselves (#549) Currently, a `Layered` struct's implementations of `Subscriber` and `Layer` will successfully downcast to either the the `Layer` type or the inner type, but *not* to `Layered<Layer, Inner>`. This means that when a `Layer` tries to downcast the wrapped subscriber to a known type, and it is a `Layered` (so, any time more than one layer wraps a subscriber and a layer other than the first one tries to downcast to the inner type it wraps), the downcast will fail incorrectly. This commit fixes the issue by checking if the downcast target `TypeId` equals the `Layered` type's `TypeId`, _before_ trying to downcast to the layer itself or to the inner type. Signed-off-by: Eliza Weisman <[email protected]> * Fix unused result * Fix last clippy warn * Minor tweeks based on eliza's suggestions * all hail our lord and savior clippy Co-authored-by: Khionu Sybiern <[email protected]> Co-authored-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Much of the way that tracing Contexts should be integrated with errors is currently up for debate but the usage of Backtrace like object for printing spans in errors has been uncontested for a while. This change removes the error integration temporarily in favor of merging a
std::backtrace::Backtrace-like API for capturing contexts from spans.