core: add a brief docs section on comparing levels #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a section to the `Level` docs explaining the comparison rules for `Level` and `LevelFilter`. It turns out this wasn't really explicitly documented anywhere. See #1274 (comment) Signed-off-by: Eliza Weisman <[email protected]>
Signed-off-by: Eliza Weisman <[email protected]>
davidbarsky
reviewed
Jun 25, 2021
davidbarsky
requested changes
Jun 25, 2021
@davidbarsky i edited one of your comments slightly to pluralize "Examples" and add whitespace, otherwise thanks for the edits. Co-authored-by: David Barsky <[email protected]>
hawkw
added a commit
that referenced
this pull request
Jun 25, 2021
This adds a section to the `Level` docs explaining the comparison rules for `Level` and `LevelFilter`. It turns out this wasn't really explicitly documented anywhere. I may have gone a bit overboard on this, but I think the new docs should be helpful... See #1274 (comment) Signed-off-by: Eliza Weisman <[email protected]> Co-authored-by: David Barsky <[email protected]>
hawkw
added a commit
that referenced
this pull request
Jun 25, 2021
This adds a section to the `Level` docs explaining the comparison rules for `Level` and `LevelFilter`. It turns out this wasn't really explicitly documented anywhere. I may have gone a bit overboard on this, but I think the new docs should be helpful... See #1274 (comment) Signed-off-by: Eliza Weisman <[email protected]> Co-authored-by: David Barsky <[email protected]>
hawkw
added a commit
that referenced
this pull request
Jun 25, 2021
This adds a section to the `Level` docs explaining the comparison rules for `Level` and `LevelFilter`. It turns out this wasn't really explicitly documented anywhere. I may have gone a bit overboard on this, but I think the new docs should be helpful... See #1274 (comment) Signed-off-by: Eliza Weisman <[email protected]> Co-authored-by: David Barsky <[email protected]>
hawkw
added a commit
that referenced
this pull request
Jun 26, 2021
This adds a section to the `Level` docs explaining the comparison rules for `Level` and `LevelFilter`. It turns out this wasn't really explicitly documented anywhere. I may have gone a bit overboard on this, but I think the new docs should be helpful... See #1274 (comment) Signed-off-by: Eliza Weisman <[email protected]> Co-authored-by: David Barsky <[email protected]>
hawkw
added a commit
that referenced
this pull request
Aug 17, 2021
# 0.1.19 (August 17, 2021) ### Added - `Level::as_str` ([#1413]) - `Hash` implementation for `Level` and `LevelFilter` ([#1456]) - `Value` implementation for `&mut T where T: Value` ([#1385]) - Multiple documentation fixes and improvements ([#1435], [#1446]) Thanks to @Folyd, @teozkr, and @dvdplm for contributing to this release! [#1413]: #1413 [#1456]: #1456 [#1385]: #1385 [#1435]: #1435 [#1446]: #1446 Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this pull request
Aug 17, 2021
# 0.1.19 (August 17, 2021) ### Added - `Level::as_str` ([#1413]) - `Hash` implementation for `Level` and `LevelFilter` ([#1456]) - `Value` implementation for `&mut T where T: Value` ([#1385]) - Multiple documentation fixes and improvements ([#1435], [#1446]) Thanks to @Folyd, @teozkr, and @dvdplm for contributing to this release! [#1413]: #1413 [#1456]: #1456 [#1385]: #1385 [#1435]: #1435 [#1446]: #1446 Signed-off-by: Eliza Weisman <[email protected]>
hawkw
added a commit
that referenced
this pull request
Aug 17, 2021
# 0.1.19 (August 17, 2021) ### Added - `Level::as_str` ([#1413]) - `Hash` implementation for `Level` and `LevelFilter` ([#1456]) - `Value` implementation for `&mut T where T: Value` ([#1385]) - Multiple documentation fixes and improvements ([#1435], [#1446]) Thanks to @Folyd, @teozkr, and @dvdplm for contributing to this release! [#1413]: #1413 [#1456]: #1456 [#1385]: #1385 [#1435]: #1435 [#1446]: #1446 Signed-off-by: Eliza Weisman <[email protected]>
kaffarell
pushed a commit
to kaffarell/tracing
that referenced
this pull request
May 22, 2024
# 0.1.19 (August 17, 2021) ### Added - `Level::as_str` ([tokio-rs#1413]) - `Hash` implementation for `Level` and `LevelFilter` ([tokio-rs#1456]) - `Value` implementation for `&mut T where T: Value` ([tokio-rs#1385]) - Multiple documentation fixes and improvements ([tokio-rs#1435], [tokio-rs#1446]) Thanks to @Folyd, @teozkr, and @dvdplm for contributing to this release! [tokio-rs#1413]: tokio-rs#1413 [tokio-rs#1456]: tokio-rs#1456 [tokio-rs#1385]: tokio-rs#1385 [tokio-rs#1435]: tokio-rs#1435 [tokio-rs#1446]: tokio-rs#1446 Signed-off-by: Eliza Weisman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a section to the
Leveldocs explaining the comparison rulesfor
LevelandLevelFilter. It turns out this wasn't reallyexplicitly documented anywhere.
I may have gone a bit overboard on this, but I think the new docs should
be helpful...
See #1274 (comment)
Signed-off-by: Eliza Weisman [email protected]