Fix potential deadlock #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Probably related to: tokio-rs/tracing#1565 |
jtescher
approved these changes
Sep 27, 2023
jtescher
added a commit
that referenced
this pull request
Nov 7, 2023
### Breaking Changes - Upgrade to `v0.21.0` of `opentelemetry` For list of breaking changes in OpenTelemetry, see the [v0.21.0 changelog](https://github.com/open-telemetry/opentelemetry-rust/blob/v0.21.0/opentelemetry/CHANGELOG.md). - Update MSRV to require Rust 1.65+, as `opentelemetry` requires it now. (#68) ### Fixed - WASM Support (#57) - Fix potential deadlock (#59)
This was referenced Feb 17, 2024
mladedav
added a commit
to mladedav/tracing-opentelemetry
that referenced
this pull request
Feb 17, 2024
This deadlock can happen when extensions of a span are locked while we visit either an event or attributes of a span. A `Debug` implementation can also try to access the extensions which results in a deadlock. See tokio-rs#59 and tokio-rs#95 for additional information.
jtescher
pushed a commit
that referenced
this pull request
Feb 26, 2024
## Motivation #94 - Mutli-threaded tracing drops most of the events ## Solution I have reorganized the code so that the lock on extensions is held, but not while `record` is called which should solve the deadlock originally solved in #59 ### Benchmark I've used the benchmark from #93, please ignore the "filtered" vs "non_filtered" distinction, for the purpose of this PR they should be identical cases. See results in later comment as the code got changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Some
Debugimplementations access a span's extensions, for example acolor_eyreReportwhen printing a Spantrace.This can currently lead to a deadlock because
tracing-opentelemetry's tracingLayerholds anextensions_mut()guard for its Span while recording the event.Solution
Move the the
OtelDataout of the span to not hold the lock and later write the extension back.