WASM Support #57
Merged
WASM Support #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add a time module at the root with a now implementation that is replaced with a js_sys call when compiling for wasm32 - use Instant from web_time when targeting wasm32 - add js_sys and web_time dependencies when targeting wasm32
jtescher
approved these changes
Aug 30, 2023
jtescher
added a commit
that referenced
this pull request
Nov 7, 2023
### Breaking Changes - Upgrade to `v0.21.0` of `opentelemetry` For list of breaking changes in OpenTelemetry, see the [v0.21.0 changelog](https://github.com/open-telemetry/opentelemetry-rust/blob/v0.21.0/opentelemetry/CHANGELOG.md). - Update MSRV to require Rust 1.65+, as `opentelemetry` requires it now. (#68) ### Fixed - WASM Support (#57) - Fix potential deadlock (#59)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I was attempting to use this library with a wasm target in a browser. If you call
std::time::{Instant, SystemTime}::nowin a wasm target, it will panic at runtime. This library makes use of both::now()calls, which will result in a panic when attempting to record a trace.Solution
In the library that this library calls (
opentelemetry-api), this is resolved by replacing calls toSystemTime::now()with an implementation that returns aSystemTimeconstructed fromjs_sys::Date. To preserve the ability to passSystemTime-typed args toopentelemetry_apimethods, I just added the same mechanism to this library.Because
Instantis never used inopentelemetry_api, we can instead replace the implementation entirely with the api-compatible "polyfill" fromweb_time.All of these changes are behind
cfgand automatically enabled when building forwasm32targets, so this will not change any behavior/performance when built for other targets.