-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to Mio v1 #6635
Update to Mio v1 #6635
Conversation
Are you able to add a test for tokio-rs/mio#1749 (review) not being breaking in Tokio? I think we may not have a test for this case. |
It seems like Tokio also has it's own version of What are you looking for in a test for this? |
E.g., calling |
Doesn't seem like |
5800fb5
to
bafbcee
Compare
Just a status update on this. Before I merge this, the following steps need to happen:
I've already prepared a PR for step 2, but I have not yet gotten around to step 1. |
Are there any updates on this? Turns out |
@nyurik the comment in #6635 (comment) is still up to date as far as I know, but due to summer vacations things are taking a little longer. I don't think there are any technical reasons this is blocked. |
The update will happen some time next week. |
@Thomasdezeeuw MSRV bump is merged. Please rebase this on master. Then I will make a release. |
Can #6154 be merged as well once Mio is updated? |
One breaking changes is the removal of mio::net::SocketAddr, replacing it with std::os::unix::net::SocketAddr. The methods on the type should be the same. For some smaller OS, such as ESP-IDF and Hermit, it can now be compiled without RUSTFLAGS.
bafbcee
to
e8f9894
Compare
Seems some new tests were added that now fail, I'll take a look at |
CI should be fixed tokio-rs/mio#1817, so that means we need a Mio release first. |
Fixes an issue with null byte being included in UDS addresses.
Once this is ready for review, mark the PR as non-draft. |
@Darksonn ready now, I was just waiting on the CI results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you.
Bumps the MSRV to 1.70.
One breaking changes is the removal of mio::net::SocketAddr, replacing it with std::os::unix::net::SocketAddr. The methods on the type should be the same.
For some smaller OS, such as ESP-IDF and Hermit, it can now be compiled without RUSTFLAGS.