Remove last null from UDS address #1817
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before passing it to SocketAddr::from_pathname. This was a problem for Tokio's test suite where uds_socket::listen_and_stream failed. We can't reproduce the problem with just Mio's type as Mio doesn't allow a UnixStream to bound to a local path before connecting it.
Thomasdezeeuw
force-pushed
the
last-null-in-accept
branch
from
13c6af9
to
b054ddc
Compare
Darksonn
approved these changes
Jul 23, 2024
Comment on lines
+116
to
+118
| if let Some(0) = path.last() { | ||
| path = &path[..path.len() - 1]; | ||
| } |
There was a problem hiding this comment.
It should only be a single null to create a C "string". The OS returns a null terminated string (though not always, I think around the max size it's not null terminated).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before passing it to SocketAddr::from_pathname.
This was a problem for Tokio's test suite where
uds_socket::listen_and_stream failed. We can't reproduce the problem with just Mio's type as Mio doesn't allow a UnixStream to bound to a local path before connecting it.