Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Wine (6.11+) to supported #1505

Merged
merged 1 commit into from
Jul 3, 2021
Merged

Conversation

Jake-Shadle
Copy link
Contributor

As noted in #1444 (comment), Wine's latest version, 6.11, has implemented the functionality necessary for mio to work correctly under wine.

While it will indeed take a while for 6.11 or higher versions to be available most distros' default package manager, Wine can still be installed in many cases directly from packages made by Wine themselves, or built from source, so I feel that listing it in the supported section with the minimum necessary version (just as with Android) is a more optimistic portrayal of support rather than a user needing to look at #1444 and read the comments to find that it is indeed supported once they acquire the necessary minimum version.

Copy link
Collaborator

@Thomasdezeeuw Thomasdezeeuw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this, although I don't use Wine myself so I'm going to have trust you that Wine 6.11 indeed works.

I'll look at the CI this weekend, since it's unrelated to the changes you can ignore it.

@Jake-Shadle
Copy link
Contributor Author

If you are game, I can make a PR to add testing under wine to CI, as I recently redid this for the main project I work on, which was the reason I was interested in #1444 to begin with.

@Thomasdezeeuw
Copy link
Collaborator

@Jake-Shadle yes would appreciate that very much.

@Thomasdezeeuw
Copy link
Collaborator

So, about the CI. We choose a "random" port we expect not be in use and guess what... another test using an OS assigned random port used that exact port :). So the accept test accepted an connection from the connect_error test, both of which didn't expect a connection at time. Restarting the CI.

@Thomasdezeeuw Thomasdezeeuw merged commit bfbcd9d into tokio-rs:master Jul 3, 2021
@Thomasdezeeuw
Copy link
Collaborator

Thanks @Jake-Shadle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants