Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cargo xwin run subcommand #9

Merged
merged 1 commit into from
Mar 7, 2022
Merged

Conversation

Sporif
Copy link
Contributor

@Sporif Sporif commented Mar 6, 2022

Couldn't run hello-tls or hello-rustls, both fail with this output:

thread 'main' panicked at 'send: reqwest::Error { kind: Request, url: Url { scheme: "http", cannot_be_a_base: false, username: "", password: None,
 host: Some(Domain("www.baidu.com")), port: None, path: "/", query: None, fragment: None }, source: hyper::Error(Connect, ConnectError("tcp connec
t error", Os { code: 66, kind: Uncategorized, message: "Bad device type." })) }', src/main.rs:7:10

Also there doesn't seem to be any run specific flags, maybe the common flags could be shared with #[clap(flatten)]?

@messense messense merged commit a274f93 into rust-cross:main Mar 7, 2022
@messense
Copy link
Member

messense commented Mar 7, 2022

The failing tests may need newer wine version. https://jake-shadle.github.io/xwin/

Debian tends to update packages at a glacial pace, as in the case of wine where the 5.0.3 version packaged in bullseye is about 9 months out of date. In this case, it actually matters, as some crates, for example mio, rely on relatively recent wine releases to implement features or fix bugs. Since mio is a foundational crate in the Rust ecosystem, we'll be installing wine's staging version, which is 6.15 at the time of this writing.

tokio-rs/mio#1444 (comment)

maybe the common flags could be shared with #[clap(flatten)]

I'll look into it, some flags have the same name and type but different help messages though.

@messense
Copy link
Member

messense commented Mar 7, 2022

Released in v0.6.0, thanks!

@messense messense added the enhancement New feature or request label Mar 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants