Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fake::driver to fake::SyscallDriver. #352

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

jrvanwhy
Copy link
Collaborator

tock/tock#2659 renamed the Tock kernel's Driver trait to SyscallDriver, because the term "driver" has too many different meanings in Tock. This change does the same, but libtock_unittest's fake version of the trait.

tock/tock#2659 renamed the Tock kernel's `Driver` trait to `SyscallDriver`, because the term "driver" has too many different meanings in Tock. This change does the same, but `libtock_unittest`'s fake version of the trait.
@jrvanwhy jrvanwhy added the significant Indicates a PR is significant as defined by the code review policy. label Dec 23, 2021
Copy link
Contributor

@hudson-ayers hudson-ayers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imo this is an upkeep PR

@jrvanwhy
Copy link
Collaborator Author

bors r+

@bors
Copy link
Contributor

bors bot commented Dec 28, 2021

Build succeeded:

@bors bors bot merged commit b2e6471 into tock:master Dec 28, 2021
hudson-ayers pushed a commit that referenced this pull request Feb 3, 2022
The only major change from upstream that this preserves is customized
external assembly linkage. This should be mostly removed once libtock
switches to using `global_asm!` - now that that will be stabilized.

This CL is a squash merge of the following commits:

28ebb70 Merge #365
a0440ba Merge #370
abff51c Merge #359
85242dc Merge #364
f1bd0d4 Merge #361
b0f8593 Merge #355
4c7ecb6 Merge #358
6f8b512 Merge #356
73cbbde Merge #357
022984f Merge #353
b2e6471 Merge #352
9eb12c0 Merge #351

This was retrieved with the following command:
```
git log ti50-internal/upstream/master --not \
  $(git merge-base --all ti50-internal/upstream/master m/main) \
  --first-parent
```

BUG=None
TEST=ti50/common make build
SOURCE=UPSTREAM(28ebb70)

Change-Id: I0aa1606f407a0b4bcf0c76b62261414903479092
@jrvanwhy jrvanwhy deleted the syscall-driver branch April 1, 2022 01:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
significant Indicates a PR is significant as defined by the code review policy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants