Skip to content

Commit

Permalink
Merge #353
Browse files Browse the repository at this point in the history
353: Remove `libtock_platform`'s asynchronous API traits. r=jrvanwhy a=jrvanwhy

These traits were designed to support a style of code I was calling "`'static` asynchrony", where upcalls are not tied to lifetimes and execution can potentially jump between unexpected modules. However [we never implemented `'static` asynchrony](#334), and I'm not sure it will ever be implemented.

Because I don't expect these traits to ever be used, I think they should be removed from `libtock_platform`.

Co-authored-by: Johnathan Van Why <[email protected]>
  • Loading branch information
bors[bot] and jrvanwhy authored Jan 4, 2022
2 parents b2e6471 + 197685b commit 022984f
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 92 deletions.
90 changes: 0 additions & 90 deletions platform/src/async_traits.rs

This file was deleted.

2 changes: 0 additions & 2 deletions platform/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

pub mod allow_ro;
pub mod allow_rw;
mod async_traits;
mod command_return;
mod constants;
mod default_config;
Expand All @@ -21,7 +20,6 @@ mod yield_types;

pub use allow_ro::AllowRo;
pub use allow_rw::AllowRw;
pub use async_traits::{CallbackContext, FreeCallback, Locator, MethodCallback};
pub use command_return::CommandReturn;
pub use constants::{exit_id, syscall_class, yield_id};
pub use default_config::DefaultConfig;
Expand Down

0 comments on commit 022984f

Please sign in to comment.