Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gdal_contour: add page #8200

Merged
merged 3 commits into from
Jul 25, 2022
Merged

Conversation

JakobMiksch
Copy link
Contributor

@JakobMiksch JakobMiksch commented Jul 11, 2022

Add the CLI tool gdal_contour from the GDAL/OGR suite.

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Version of the command being documented (if known):
3.2.2

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Jul 11, 2022
Copy link
Collaborator

@reinhart1010 reinhart1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be better to place some mnemonic tags here, as gdal_contour unfortunately doesn't put longer parameter names (e.g. --attribute instead of -a) which are more preferred in writing tldr-pages.

pages/common/gdal_contour.md Outdated Show resolved Hide resolved
pages/common/gdal_contour.md Outdated Show resolved Hide resolved
Co-authored-by: Reinhart Previano Koentjoro <[email protected]>
@JakobMiksch
Copy link
Contributor Author

@reinhart1010 thanks for your review, I applied your suggestions.

@navarroaxel navarroaxel added the review needed Prioritized PRs marked for reviews from maintainers. label Jul 19, 2022
Copy link
Collaborator

@marchersimon marchersimon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

Copy link
Collaborator

@reinhart1010 reinhart1010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@reinhart1010 reinhart1010 merged commit 5c490a5 into tldr-pages:main Jul 25, 2022
@JakobMiksch JakobMiksch deleted the gdal_contour branch July 25, 2022 06:40
@navarroaxel navarroaxel removed the review needed Prioritized PRs marked for reviews from maintainers. label Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants