Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slmgr, slmgr.vbs: add page #8201

Merged
merged 6 commits into from
Jul 16, 2023
Merged

slmgr, slmgr.vbs: add page #8201

merged 6 commits into from
Jul 16, 2023

Conversation

reinhart1010
Copy link
Collaborator

  • The page (if new), does not already exist in the repository.
  • The page is in the correct platform directory (common/, linux/, etc.)
  • The page has 8 or fewer examples.
  • The PR title conforms to the recommended templates.
  • The page follows the content guidelines.
  • The page description includes a link to documentation or a homepage (if applicable).

Version of the command being documented (if known): Windows 10 (also applies to Windows 7 and up)

The official program name for this is slmgr.vbs. However, users might be bothered after finding out they need to use tldr slmgr.vbs instead of tldr slmgr to view this documentation. This is why I decided to set the otherwise, where slmgr.vbs is an alias of slmgr. This will also be useful for documenting other Windows-specific .vbs scripts such as ospp.vbs as long as the unprefixed command is still acceptable for use in the Command Prompt.

@github-actions github-actions bot added the new command Issues requesting creation of a new page. label Jul 12, 2022
@tldr-bot

This comment was marked as resolved.

@marchersimon
Copy link
Collaborator

@reinhart1010 if the official name includes the .vbs and you have to call it with slmgr.vbs, we should use this as the main page and add slmgr as an alias page

pages/windows/slmgr.md Outdated Show resolved Hide resolved
pages/windows/slmgr.md Outdated Show resolved Hide resolved
pages/windows/slmgr.md Outdated Show resolved Hide resolved
pages/windows/slmgr.md Outdated Show resolved Hide resolved
pages/windows/slmgr.md Outdated Show resolved Hide resolved
pages/windows/slmgr.md Outdated Show resolved Hide resolved
pages/windows/slmgr.md Outdated Show resolved Hide resolved
pages/windows/slmgr.md Outdated Show resolved Hide resolved
pages/windows/slmgr.md Outdated Show resolved Hide resolved
@reinhart1010
Copy link
Collaborator Author

Anyway I've already swapped the alias page and apply case-sensitive tags (e.g. [d]isplay instead of [D]isplay) here

pages/windows/slmgr.vbs.md Outdated Show resolved Hide resolved
Comment on lines +31 to +37
- [c]lear the current license's [p]roduct [k]e[y] from the Windows Registry. This will not deactivate or uninstall the current license, but prevents the key from being stolen by malicious programs in the future:

`slmgr /cpky`

- [u]ninstall the current license (by its [p]roduct [k]ey):

`slmgr /upk`
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need those two command Administrator privileges?

pages/windows/slmgr.vbs.md Outdated Show resolved Hide resolved
pages/windows/slmgr.vbs.md Outdated Show resolved Hide resolved
@github-actions

This comment was marked as outdated.

@github-actions github-actions bot added the waiting Issues/PRs with Pending response by the author. label Aug 22, 2022
@EmilyGraceSeville7cf EmilyGraceSeville7cf added stalebot ignore and removed waiting Issues/PRs with Pending response by the author. labels Aug 22, 2022
navarroaxel and others added 2 commits September 26, 2022 09:30
Co-authored-by: Emily Grace Seville <[email protected]>
Co-authored-by: marchersimon <[email protected]>
@CLAassistant
Copy link

CLAassistant commented Dec 28, 2022

CLA assistant check
All committers have signed the CLA.

@reinhart1010
Copy link
Collaborator Author

Oh, sounds like a new CLA has arrived since.

@kbdharun
Copy link
Member

kbdharun commented May 16, 2023

Oh, sounds like a new CLA has arrived since.

It isn't a new CLA, the old CLA spelt TDLR pages instead of TLDR pages, and I requested Waldyrus to update it, he updated it in his Gist file, which contains the CLA (as CLA Assitant only supports GitHub Gists), even though it was a single character edit, CLA Assistant flagged it as a change to the terms and invalidated the existing people who signed the CLA.

@kbdharun kbdharun added the review needed Prioritized PRs marked for reviews from maintainers. label May 16, 2023
@Waples
Copy link
Member

Waples commented Jun 18, 2023

I'm not signing off on this one yet, something I'm looking into..

@blueskyson blueskyson merged commit 5b418a7 into tldr-pages:main Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new command Issues requesting creation of a new page. review needed Prioritized PRs marked for reviews from maintainers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants