-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
multiple pages: fix French colon punctuation #5152
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are just a few of the issues - I think your regex went a bit wrong lol
The last character has been replaced with a space, rather than a space being inserted.
Finally, does that strange space character mean anything in particular in French? Best to check before changing it.
@sbrl, you're right!! Funny 😄
I changed it because more pages have a normal space (139 pages) than ones that have the strange one (5), and that space was also in an English page... |
86ce8cf
to
f8e6683
Compare
@sbrl I found a bunch more of that mistake so I just went back to the beginning and re-did it all. Done now ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've once seen someone explaining this weird space here in tldr but I cannot remember what is the reason for it.
@schneiderl could you be thinking of #3446 (comment)? |
😬 I fear that I was wrong about the space...maybe there should be a |
Indeed, as I said in the comment you reported, French typographic rules require this non-breaking space before some punctuation characters (":", ";", "?" and "!" in particular). Replacing those by a normal space (0x20) would potentially break the layout by putting the punctuation character alone at the beginning of a line. |
@julienc91 okay, thank you very much. I didn't know this. @mebeim mentioned in #3446 (comment) "Indeed a space before and after the colon should be used" —so there should be a non-breaking space after the colon as well as before? |
@mebeim A non-breaking space before the colon, and a normal space after.
But this is not:
|
Really nice, thank you @julienc91. Is the space after the
We wouldn't need to add a space after that, would we? |
No space after if you have a line return character right after. Regex style (with 0xa0 and 0x20 being respectively the non breaking space and the normal space):
|
Okay, thank you @julienc91. This is very good to know. Now I will proceed. By the way, it's |
@bl-ue looks good to me! Also, "ex" is shorthand "example", while "ici" just means "here", so I guess it depends on the context? I didn't see any error in the 3 occurrences I found. |
Okay! I was just wondering if perhaps someone who translated those pages missed something :) Thank you very much @julienc91 for your help! You've been extremely helpful! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! I assume the regular space was swapped for a non-breaking one right?
Exactly. |
Note: Just in case anyone forgets, please squash this PR and do not rebase it. The commit history is a little messy because I was learning the whole way through :) |
Ensures that there is always one space character before colons (
0xa0
thin unbreakable space instead of0x20
normal space) in French pages.