Added documentation about travis token #1902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice 👍 Please also mention that the upload is done via the |
|
For future reference, this PR is a follow-up to #1899. |
5 tasks
sbrl
approved these changes
Jan 18, 2018
waldyrious
requested changes
Jan 18, 2018
|
@waldyrious - PTAL |
waldyrious
reviewed
Jan 18, 2018
scripts/build.sh
Outdated
| @@ -28,6 +28,7 @@ function build_archive { | |||
| } | |||
|
|
|||
| function upload_assets { | |||
| # ${GH_TOKEN} is referred from the secure variable inside .travis.yml | |||
There was a problem hiding this comment.
How about "referred from the secure variable inside .travis.yml" --> "defined as a secure variable in .travis.yml"?
There was a problem hiding this comment.
Also, I'd add a comment at the top of this file, saying something like:
# This script is executed by Travis CI when a PR is merged (i.e. in the `after_success` step).
waldyrious
approved these changes
Jan 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/cc @waldyrious