Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using new travis token #1899

Merged
merged 1 commit into from
Jan 18, 2018
Merged

Using new travis token #1899

merged 1 commit into from
Jan 18, 2018

Conversation

agnivade
Copy link
Member

Used my token here.

Travis seems to be down. Will test it once it's up.

@agnivade
Copy link
Member Author

xref #1878

@waldyrious
Copy link
Member

waldyrious commented Jan 17, 2018

Are you planning to remove the other token?

Also, don't forget the documentation :) from #1878 (comment):

we definitely should add a comment to that file noting the token on .travis.yml, and the comment on .travis.yml should mention the upload_assets() function on this file.

@agnivade
Copy link
Member Author

First I wanted to verify that this thing works. :) Will update the documentation once its working.

Yes, there can only be one token at a time.

@waldyrious
Copy link
Member

waldyrious commented Jan 17, 2018

Cool. Btw, looks like Travis is working well again, so I've restarted the build. Let's wait and see! Looks like it worked! :D

@agnivade agnivade merged commit ec85c43 into master Jan 18, 2018
@agnivade agnivade deleted the token branch January 18, 2018 03:26
@agnivade
Copy link
Member Author

You would only be able to test it once you merge with master. Yes, now it works !

@waldyrious
Copy link
Member

Right, forgot about that detail :P

@bl-ue bl-ue added page edit Changes to an existing page(s). tooling Helper tools, scripts and automated processes. labels Apr 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
page edit Changes to an existing page(s). tooling Helper tools, scripts and automated processes.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants