Improve git-ignore command
#1047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spacewander
reviewed
May 18, 2023
bin/git-ignore
Outdated
| @@ -34,22 +46,22 @@ function add_global { | |||
| } | |||
|
|
|||
| function show_local { | |||
| cd "$(git root)" | |||
| maybe_cd_to_git_root | |||
There was a problem hiding this comment.
We should warn the user if this cmd doesn't run in git repo.
See #347 (comment)
| @@ -11,18 +11,30 @@ function show_contents { | |||
| fi | |||
| } | |||
|
|
|||
| function maybe_cd_to_git_root { | |||
| local result= | |||
| if result=$(git rev-parse --show-toplevel 2>/dev/null); then | |||
There was a problem hiding this comment.
Let's add this cmd in https://github.com/tj/git-extras/blob/master/not_need_git_repo
| add_patterns .gitignore "$@" | ||
| } | ||
|
|
||
| function show_private { | ||
| cd "$(git root)" | ||
| maybe_cd_to_git_root | ||
| show_contents Private "${GIT_DIR}/info/exclude" |
There was a problem hiding this comment.
We must require a git repo for setting the private ignorefile. As it's private to the git repo.
|
Sorry for the slow reply, I have addressed the feedback |
spacewander
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #38
git ignore<TAB>now shows file/directory namesCloses #347
Closes #427 (stale issue about file that does not exist)