Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed the issue regarding using proxies with the previous implementation #191

Merged
merged 10 commits into from
Oct 26, 2023
Merged

Fixed the issue regarding using proxies with the previous implementation #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
149ecb4
#33012: Tests for proxy, other Octokit library, multiple test configs
janssen-tiobe Oct 17, 2023
dc51d3b
#33012: Wrote tests for retries for http-client
janssen-tiobe Oct 18, 2023
a0fef1a
#33012: Trying fix for testing unavailable github url
janssen-tiobe Oct 18, 2023
6ee18d8
#33012: Merged main into branch
janssen-tiobe Oct 18, 2023
534b3bc
#33012: Merged main into branch again
janssen-tiobe Oct 18, 2023
2335303
#33012: Added GITHUB_TOKEN for tests in TICS workflows
janssen-tiobe Oct 18, 2023
731eba5
#33012: Reimplemented octokit again, tests for no_proxy
janssen-tiobe Oct 23, 2023
bff2eb4
#33012: Small refactor
janssen-tiobe Oct 23, 2023
92be5bb
#33012: Complete overhaul of http-client and install-tics
janssen-tiobe Oct 25, 2023
a88d555
#33012: Possible fix for failing test that passes locally
janssen-tiobe Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,6 @@ jobs:
- name: Jest
uses: actions/setup-node@v3
- run: npm ci
- run: npm run test-coverage
- run: npm run test:coverage
env:
INPUT_GITHUBTOKEN: ${{ secrets.GITHUB_TOKEN }}
4 changes: 3 additions & 1 deletion .github/workflows/tics-analyzer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,9 @@ jobs:
- name: Setup Node.js environment
uses: actions/setup-node@v3
- run: npm ci
- run: npm run test-coverage
- run: npm run test:coverage
env:
INPUT_GITHUBTOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: Install and run TICSQSERVER
env:
TICSAUTHTOKEN: ${{ secrets.EBOIT_ANALYZER_TOKEN }}
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/tics-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,9 @@ jobs:
- name: Setup Node.js environment
uses: actions/setup-node@v3
- run: npm ci
- run: npm run test:coverage
env:
INPUT_GITHUBTOKEN: ${{ secrets.GITHUB_TOKEN }}
- name: TICS GitHub Action
uses: tiobe/tics-github-action@v2
with:
Expand Down
2 changes: 2 additions & 0 deletions .npmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
@tiobe:registry=https://artifacts.tiobe.com/repository/npm/
registry=https://registry.npmjs.org
2 changes: 2 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,7 @@ The following inputs are available for this action:
| `postAnnotations` | Show the latest TICS annotations directly in the GitHub Pull Request review. | false |
| `postToConversation` | Post the summary to the conversation page of the pull request. Options are `true` (default) or `false`. | false |
| `pullRequestApproval` | Set the plugin to approve or deny a pull request, by default this is false. Options are `true` or `false`. Note that once a run that added a reviewer has been completed, this reviewer cannot be deleted from that pull request. (Always the case on versions between 2.0.0 and 2.5.0). | false |
| `retryCodes` | Status codes to retry api calls for. The default codes will be overwritten if this option is set. | false |
| `secretsFilter` | Comma-seperated list of extra secrets to mask in the console output. | false |
| `ticsAuthToken` | Authentication token to authorize the plugin when it connects to the TICS Viewer. | false |
| `tmpDir` | Location to store debug information. | false |
Expand All @@ -95,6 +96,7 @@ The following inputs are available for this action:
- To package the build to run run `npm run package`.
- To combine the last two steps run `npm run all`.
- There is Prettier auto-formatting available, run `npm run format` or enable format on save to automate the formatting.
- In order to run the tests the environment variable `INPUT_GITHUBTOKEN` needs to be set with a valid `GITHUB_TOKEN`

## Git hooks

Expand Down
3 changes: 3 additions & 0 deletions action.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,9 @@ inputs:
description: Set the plugin to approve or deny a pull request, by default this is false. Options are `true` or `false`. Note that once a run that added a reviewer has been completed, this reviewer cannot be deleted from that pull request. (Always the case on versions between 2.0.0 and 2.5.0).
required: false
default: false
retryCodes:
description: Status codes to retry api calls for. The default codes will be overwritten if this option is set.
required: false
secretsFilter:
description: Comma-seperated list of extra secrets to mask in the console output.
required: false
Expand Down
Loading