Fixed the issue regarding using proxies with the previous implementation #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests for proxy, they reproduced the issue, now it passes. Made multiple configs for Jest as proxy did not work with the existing mocks.
Renamed test-coverage to more conventional test:coverage, added tests for error.ts
janssen-tiobe
force-pushed
the
33012-retry_proxy
branch
from
6ded028 to
6ee18d8
Compare
Now using `@tiobe/http-client` and `@tiobe/install-tics` to retrieve data from the viewer and to get the install TICS url from the viewer. Rewrote the testing for it and fixed the proxy setup, which now passes the local tests as well as the unit tests. To do this I had to revert some libraries to get it to work.
TICS Quality Gate✔️ Passed0 Condition(s) failedSee the results in the TICS Viewer The following files have been checked:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.