-
Notifications
You must be signed in to change notification settings - Fork 918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
compileopts, targets, main: support Wasmtime v14 #3972
Conversation
9cf14f4
to
e801cdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
The reason the CI tests are failing here, is because the change in this PR is not backward compatible with the old version (v5.0.0) of wasmtime being used for testing. For example, see https://github.com/tinygo-org/tinygo/blob/dev/.github/workflows/linux.yml#L143 So do we want to do one of these?
Thoughts? |
In the meantime, how about #3976 to get our build back to green? |
@deadprogram thsnks! I'll rebase and pin this PR to v14. Looks like Homebrew just updated to v14 yesterday: https://github.com/Homebrew/homebrew-core/blob/581c110863a917ada65b58cf046d93c2a2f6d105/Formula/w/wasmtime.rb |
e801cdc
to
4ff1faa
Compare
@deadprogram rebased, now green. |
It appears that Wasmtime will issue a patch release with backwards compatibility: bytecodealliance/wasmtime#7336 (comment)
|
Wasmtime v14 (released 2023-10-20) has a breaking change in how CLI arguments are processed. 1. Arguments after the .wasm module to run are passed to the Wasm module. The -- flag has no effect. 2. --mapdir becomes --dir, and the arguments are reversed: --dir=HOST:GUEST
TODO: maybe put Wasmtime version in a variable?
eaa6a2b
to
21b674b
Compare
Wasmtime v14.0.4 should be released this morning, which fixes known outstanding bugs with running This PR adapts the old CLI to the new (v14+) CLI, so could probably be merged anytime before Wasmtime drops backwards compatibility. |
Thanks for helping get this settled @ydnar now going to squash/merge |
compileopts, targets, main: support Wasmtime v14
This PR adds support for Wasmtime v14 (released 2023-10-20), reenabling support for:
tinygo test -v -target=wasi ./...
--mapdir=GUEST::HOST
to--dir=HOST::GUEST
wasmtime
so Wasmtime arguments are before the.wasm
module argument, and arguments to the Go program (e.g.-test.v
) are after. The--
argument has no effect.Note this PR does not attempt to detect the version of Wasmtime being run.
For additional context, see:
Fixes #3970.