Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wasmtime v14 breaks -target=wasi #3970

Closed
ydnar opened this issue Oct 21, 2023 · 5 comments · Fixed by #3972
Closed

wasmtime v14 breaks -target=wasi #3970

ydnar opened this issue Oct 21, 2023 · 5 comments · Fixed by #3972

Comments

@ydnar
Copy link
Contributor

ydnar commented Oct 21, 2023

Wasmtime v14 introduced a new CLI structure, with two changes relevant to TinyGo:

https://github.com/bytecodealliance/wasmtime/blob/main/RELEASES.md#1400

  1. --mapdir=GUEST::HOST becomes --dir=HOST::GUEST: Swap the order of directories in --dir bytecodealliance/wasmtime#7301
  2. Arguments after the Wasm module to run are passed to the guest, instead of arguments after --: Redesign Wasmtime's CLI bytecodealliance/wasmtime#6925
@deadprogram
Copy link
Member

Tagged to close this issue after next release.

@dgryski
Copy link
Member

dgryski commented Nov 4, 2023

We still need to update argument construction if we haven't already.

@ydnar
Copy link
Contributor Author

ydnar commented Nov 4, 2023

I think argument construction is correct now.

@dgryski
Copy link
Member

dgryski commented Nov 4, 2023

Ah yes, thanks. Was trying to figure out why I was getting this warning from wasmtime. Needed to rebase my branch against the latest dev:

~/go/src/github.com/dgryski/bug/intf $ tinygo run -target=wasi main.go
warning: this CLI invocation of Wasmtime will be parsed differently in future
         Wasmtime versions -- see this online issue for more information:
         https://github.com/bytecodealliance/wasmtime/issues/7384

         Wasmtime will now execute with the old (<= Wasmtime 13) CLI parsing,
         however this behavior can also be temporarily configured with an
         environment variable:

         - WASMTIME_NEW_CLI=0 to indicate old semantics are desired and silence this warning, or
         - WASMTIME_NEW_CLI=1 to indicate new semantics are desired and use the latest behavior

@deadprogram
Copy link
Member

Completed with v0.31.0 so now closing. Thank you!

@deadprogram deadprogram removed the next-release Will be part of next release label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants