Skip to content

Restructure transforms #420

Merged
merged 9 commits into from
Dec 29, 2021
Merged

Restructure transforms #420

merged 9 commits into from
Dec 29, 2021

Conversation

julia-shenshina
Copy link
Contributor

@julia-shenshina julia-shenshina commented Dec 28, 2021

IMPORTANT: Please do not create a Pull Request without creating an issue first.

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Type of Change

  • Examples / docs / tutorials / contributors update
  • Bug fix (non-breaking change which fixes an issue)
  • Improvement (non-breaking change which improves an existing feature)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Proposed Changes

Related Issue

Closing issues

#403

@codecov-commenter
Copy link

codecov-commenter commented Dec 28, 2021

Codecov Report

Merging #420 (3592368) into master (0e1f7c1) will increase coverage by 0.15%.
The diff coverage is 99.29%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #420      +/-   ##
==========================================
+ Coverage   87.13%   87.28%   +0.15%     
==========================================
  Files          99      111      +12     
  Lines        5067     5127      +60     
==========================================
+ Hits         4415     4475      +60     
  Misses        652      652              
Impacted Files Coverage Δ
...na/transforms/decomposition/change_points_trend.py 99.04% <ø> (ø)
etna/transforms/decomposition/detrend.py 98.33% <ø> (ø)
etna/transforms/decomposition/stl.py 94.02% <ø> (ø)
etna/transforms/encoders/segment_encoder.py 100.00% <ø> (ø)
etna/transforms/feature_selection/base.py 100.00% <ø> (ø)
etna/transforms/feature_selection/filter.py 100.00% <ø> (ø)
etna/transforms/math/add_constant.py 97.61% <ø> (ø)
etna/transforms/math/lags.py 100.00% <ø> (ø)
etna/transforms/math/log.py 97.82% <ø> (ø)
etna/transforms/math/sklearn.py 95.32% <ø> (ø)
... and 28 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e1f7c1...3592368. Read the comment docs.

@julia-shenshina julia-shenshina self-assigned this Dec 28, 2021
@julia-shenshina julia-shenshina linked an issue Dec 28, 2021 that may be closed by this pull request
1 task
etna/transforms/feature_selection/__init__.py Show resolved Hide resolved
etna/transforms/math/__init__.py Show resolved Hide resolved
etna/transforms/math/__init__.py Show resolved Hide resolved
etna/transforms/outliers/__init__.py Show resolved Hide resolved
@julia-shenshina julia-shenshina marked this pull request as ready for review December 29, 2021 14:20
@julia-shenshina julia-shenshina requested review from Mr-Geekman and removed request for martins0n and alex-hse-repository December 29, 2021 14:26
from etna.transforms.timestamp import FourierTransform
from etna.transforms.timestamp import HolidayTransform
from etna.transforms.timestamp import SpecialDaysTransform
from etna.transforms.timestamp import TimeFlagsTransform
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are 40 lines in a new file and 41 in the old version. It is strange.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's true
I didn't add import for BaseFeatureSelectionTransform at the top level of transforms because this class seems to be not very useful for users

@julia-shenshina julia-shenshina merged commit 9eedbd6 into master Dec 29, 2021
@julia-shenshina julia-shenshina deleted the issue403 branch December 29, 2021 15:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate transforms by groups by its meaning
4 participants