Skip to content

Separate transforms by groups by its meaning #403

Closed
1 task
Mr-Geekman opened this issue Dec 21, 2021 · 0 comments · Fixed by #420
Closed
1 task

Separate transforms by groups by its meaning #403

Mr-Geekman opened this issue Dec 21, 2021 · 0 comments · Fixed by #420
Assignees
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Milestone

Comments

@Mr-Geekman
Copy link
Contributor

Mr-Geekman commented Dec 21, 2021

🚀 Feature Request

Separate transforms by groups by its meaning. It can help to make all of them usable.

Suggested groups:

  1. Decomposition
    • change_point_trend.py
    • binseg.py
    • trend.py
    • detrend.py
    • stl.py
  2. Feature Selection
    • filter.py
    • feature_selection.py
    • feature_importance.py
    • gale_shapley.py
  3. Time
    • datetime_flags.py
    • fourier.py
    • holiday.py
    • lags.py
    • special_days.py
    • statistics.py
  4. Math
    • add_constant.py
    • log.py
    • sklearn.py
    • scalers.py
    • power.py
  5. Missing values
    • outliers.py
    • imputation.py
    • resample.py
  6. Encoders
    • segment_encoder.py
  7. NN
    • pytorch_forecasting.py

File base.py can be placed in the root of transforms/ folder.

Motivation

There are a lot of transforms and it can confuse a lot of users. If transform will be grouped by its meaning it will be easier to use the library.

Proposal

  1. Separate transforms by the groups into folders.
  2. Separate tests for transforms by the same groups.
  3. Check that documentation shows these groups.

Test cases

No response

Alternatives

No response

Additional context

No response

Checklist

  • I discussed this issue with ETNA Team
@Mr-Geekman Mr-Geekman added documentation Improvements or additions to documentation enhancement New feature or request labels Dec 21, 2021
@Mr-Geekman Mr-Geekman moved this to Specification in etna board Dec 21, 2021
@julia-shenshina julia-shenshina self-assigned this Dec 28, 2021
@julia-shenshina julia-shenshina moved this from Specification to Todo in etna board Dec 28, 2021
@julia-shenshina julia-shenshina moved this from Todo to In Progress in etna board Dec 28, 2021
@julia-shenshina julia-shenshina linked a pull request Dec 28, 2021 that will close this issue
9 tasks
@julia-shenshina julia-shenshina moved this from In Progress to In Review in etna board Dec 28, 2021
Repository owner moved this from In Review to Done in etna board Dec 29, 2021
@martins0n martins0n added this to the etna 1.6.0 milestone Jan 26, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants