Inherit target platforms on test modules #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull request #6 uncovered a problem in `ArtefactResolution`: When a test module did not set any target platforms, its dependencies would not be resolved.
Currently, the logic in `BuildConfig` only considers the platform-specific modules defined on a test module. Change the logic to inherit all targets from the parent module. Change the type of `import` on `Build` to `Path` to avoid the duplicated normalisation logic of `fixPath()`. Also, break `load()` on `Build` apart into separate functions to allow for better testing.
tindzk
force-pushed
the
bug/test-dep-resolution
branch
from
f54884d
to
351a6de
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request #6 uncovered a problem in
ArtefactResolution: When a test module did not set any target platforms, its dependencies would not be resolved.Currently, the logic in
BuildConfigonly considers the platform-specific modules defined on a test module. Change the logic to inherit all targets from the parent module.Change the type of
importonBuildtoPathto avoid the duplicated normalisation logic offixPath().Also, break
load()onBuildapart into separate functions to allow for better testing.