Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inherit target platforms on test modules #7

Merged
merged 2 commits into from
Jan 27, 2019
Merged

Inherit target platforms on test modules #7

merged 2 commits into from
Jan 27, 2019

Commits on Jan 27, 2019

  1. ArtefactResolution: Inherit target platforms from parent 

    Pull request #6 uncovered a problem in `ArtefactResolution`: When a
test module did not set any target platforms, its dependencies would
not be resolved.
    @tindzk
    tindzk committed Jan 27, 2019
    Configuration menu
    Copy the full SHA
    14d0380 View commit details
    Browse the repository at this point in the history

  2. BuildConfig: Detect target platforms of test module if unspecified 

    Currently, the logic in `BuildConfig` only considers the
platform-specific modules defined on a test module. Change the logic
to inherit all targets from the parent module.

Change the type of `import` on `Build` to `Path` to avoid the
duplicated normalisation logic of `fixPath()`.

Also, break `load()` on `Build` apart into separate functions to
allow for better testing.
    @tindzk
    tindzk committed Jan 27, 2019
    Configuration menu
    Copy the full SHA
    351a6de View commit details
    Browse the repository at this point in the history