Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Idea: Fix path normalisation #5

Merged
merged 2 commits into from
Jan 27, 2019
Merged

Idea: Fix path normalisation #5

merged 2 commits into from
Jan 27, 2019

Commits on Jan 27, 2019

  1. Idea: Fix path normalisation 

    When a build file imported external modules, the `idea` command
could fail with an exception thrown by `relativize()`. This commit
addresses various corner cases and consolidates the logic for path
normalisation.

Also, `BuildConfig` was changed to prefer a relative build project
path as this value gets propagated to the generators.
    @tindzk
    tindzk committed Jan 27, 2019
    Configuration menu
    Copy the full SHA
    d910ac4 View commit details
    Browse the repository at this point in the history

  2. Coursier: Introduce re-entrant lock to prevent concurrent access 

    The new tests introduced in the previous commit could result in
multiple dependency resolutions being triggered at the same time if
artefacts were not cached locally. This was causing Drone CI
builds to fail. Avoid concurrent access during dependency resolution
by using a re-entrant lock.

Also, make sure that the logger is only initialised once.
    @tindzk
    tindzk committed Jan 27, 2019
    Configuration menu
    Copy the full SHA
    ed725aa View commit details
    Browse the repository at this point in the history