Idea: Fix path normalisation #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tindzk
force-pushed
the
bug/idea-modules
branch
2 times, most recently
from
9990725
to
3367af3
Compare
When a build file imported external modules, the `idea` command could fail with an exception thrown by `relativize()`. This commit addresses various corner cases and consolidates the logic for path normalisation. Also, `BuildConfig` was changed to prefer a relative build project path as this value gets propagated to the generators.
The new tests introduced in the previous commit could result in multiple dependency resolutions being triggered at the same time if artefacts were not cached locally. This was causing Drone CI builds to fail. Avoid concurrent access during dependency resolution by using a re-entrant lock. Also, make sure that the logger is only initialised once.
tindzk
force-pushed
the
bug/idea-modules
branch
from
3367af3
to
ed725aa
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a build file imported external modules, the
ideacommand could fail with an exception thrown byrelativize(). This commit addresses various corner cases and consolidates the logic for path normalisation.Also,
BuildConfigwas changed to prefer a relative build project path as this value gets propagated to the generators.The new tests could result in multiple dependency resolutions being triggered at the same time if artefacts were not cached locally. This was causing Drone CI builds to fail. Avoid concurrent access during dependency resolution by using a re-entrant lock.
Finally, make sure that the logger is only initialised once.