Remove "target" from build.json

So that compilerOptions.target is pulled from the base tsconfig instead Fixes isaacs#54
timovv · Mar 21, 2024 · 08d456d · 08d456d
1 parent 8fda22e
commit 08d456d
Show file tree

Hide file tree

Showing 9 changed files with 2 additions and 13 deletions.
diff --git a/.tshy/build.json b/.tshy/build.json
@@ -2,7 +2,6 @@
   "extends": "../tsconfig.json",
   "compilerOptions": {
     "rootDir": "../src",
-    "target": "es2022",
     "module": "nodenext",
     "moduleResolution": "nodenext"
   }

diff --git a/README.md b/README.md
@@ -572,7 +572,7 @@ in `src/<whatever>.ts` and the CommonJS polyfill living in
 
 If you want to keep some files from being processed by tshy's
 builds entirely, you can add an `exclude` `string[]` field to the
-`tshy` object in `package.json`.  For example:
+`tshy` object in `package.json`. For example:
 
 ```json
 {
@@ -701,7 +701,6 @@ following caveats:
   - `outDir` - will be overridden based on build, best omitted
   - `rootDir` - will be set to `./src` in the build, can only
     cause annoying errors otherwise.
-  - `target` - will be set to `es2022`
   - `module` - will be set to `NodeNext`
   - `moduleResolution` - will be set to `NodeNext`
 
@@ -721,7 +720,7 @@ tsconfig file. This is often useful when you have multiple
   `typescript-eslint`, specifying `"noEmit": true` and
   `"include": ["**/*.ts"]`
 - A `tsconfig.build.json` for compilation, with `"noEmit":
-  false`. Note that the [caveats](#tsconfigs) above still apply.
+false`. Note that the [caveats](#tsconfigs) above still apply.
 
 ```json
 {

diff --git a/src/tsconfig.ts b/src/tsconfig.ts
@@ -50,7 +50,6 @@ const build: Record<string, any> = {
       : join('..', config.project),
   compilerOptions: {
     rootDir: '../src',
-    target: 'es2022',
     module: 'nodenext',
     moduleResolution: 'nodenext',
   },

diff --git a/tap-snapshots/test/tsconfig.ts.test.cjs b/tap-snapshots/test/tsconfig.ts.test.cjs
@@ -11,7 +11,6 @@ Object {
     "module": "nodenext",
     "moduleResolution": "nodenext",
     "rootDir": "../src",
-    "target": "es2022",
   },
   "extends": "../custom.json",
 }
@@ -104,7 +103,6 @@ Object {
     "module": "nodenext",
     "moduleResolution": "nodenext",
     "rootDir": "../src",
-    "target": "es2022",
   },
   "extends": "../tsconfig.json",
 }
@@ -116,7 +114,6 @@ Object {
     "module": "nodenext",
     "moduleResolution": "nodenext",
     "rootDir": "../src",
-    "target": "es2022",
   },
   "extends": "../tsconfig.json",
 }

diff --git a/test/fixtures/basic-custom-project/.tshy/build.json b/test/fixtures/basic-custom-project/.tshy/build.json
@@ -2,7 +2,6 @@
   "extends": "../tsconfig.custom.json",
   "compilerOptions": {
     "rootDir": "../src",
-    "target": "es2022",
     "module": "nodenext",
     "moduleResolution": "nodenext"
   }

diff --git a/test/fixtures/basic-imports-only-deps/.tshy/build.json b/test/fixtures/basic-imports-only-deps/.tshy/build.json
@@ -2,7 +2,6 @@
   "extends": "../tsconfig.json",
   "compilerOptions": {
     "rootDir": "../src",
-    "target": "es2022",
     "module": "nodenext",
     "moduleResolution": "nodenext"
   }

diff --git a/test/fixtures/basic/.tshy/build.json b/test/fixtures/basic/.tshy/build.json
@@ -2,7 +2,6 @@
   "extends": "../tsconfig.json",
   "compilerOptions": {
     "rootDir": "../src",
-    "target": "es2022",
     "module": "nodenext",
     "moduleResolution": "nodenext"
   }

diff --git a/test/fixtures/imports-with-star/.tshy/build.json b/test/fixtures/imports-with-star/.tshy/build.json
@@ -2,7 +2,6 @@
   "extends": "../tsconfig.json",
   "compilerOptions": {
     "rootDir": "../src",
-    "target": "es2022",
     "module": "nodenext",
     "moduleResolution": "nodenext"
   }

diff --git a/test/fixtures/imports/.tshy/build.json b/test/fixtures/imports/.tshy/build.json
@@ -2,7 +2,6 @@
   "extends": "../tsconfig.json",
   "compilerOptions": {
     "rootDir": "../src",
-    "target": "es2022",
     "module": "nodenext",
     "moduleResolution": "nodenext"
   }