-
-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow compilerOptions.target to flow from base tsconfig #54
Comments
Hm, I don't have a good answer for this one. Maybe it should just be in the default |
@isaacs could we make this configurable then from our standpoint to specify that in the base |
Hm, since it's defaulting in the For posterity if anyone comes searching and finds this issue, can you share what situation you're finding where it needs to be different? |
@isaacs For example, we shipped our new Azure SDK Core JavaScript libraries which were previously targeting ES2020/ES2017. Some of our customers complained once upgrading that their TypeScript version did not support particular syntax which were in ES2022 such as this issue: Azure/azure-sdk-for-js#28918 |
Ahhh, yes, node 14. Cool, makes sense. |
So that compilerOptions.target is pulled from the base tsconfig instead Fixes isaacs#54
So that compilerOptions.target is pulled from the base tsconfig instead Fixes isaacs#54
Fixed by #55 |
I am wondering why
es2022
was hardcoded in the basebuild.json
in the.tshy
folder. Could that be configurable or is there a particular ES2022 set that you are using for tshy specifically?The text was updated successfully, but these errors were encountered: