Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow compilerOptions.target to flow from base tsconfig #54

Closed
mpodwysocki opened this issue Mar 20, 2024 · 7 comments
Closed

Allow compilerOptions.target to flow from base tsconfig #54

mpodwysocki opened this issue Mar 20, 2024 · 7 comments

Comments

@mpodwysocki
Copy link
Contributor

I am wondering why es2022 was hardcoded in the base build.json in the .tshy folder. Could that be configurable or is there a particular ES2022 set that you are using for tshy specifically?

@isaacs
Copy link
Owner

isaacs commented Mar 20, 2024

Hm, I don't have a good answer for this one. Maybe it should just be in the default tsconfig.json? Istr something not working when target isn't set, but tbh I don't recall what it was, or if that option was just thrown at the wall to see what sticks.

@mpodwysocki
Copy link
Contributor Author

@isaacs could we make this configurable then from our standpoint to specify that in the base tsconfig?

@isaacs
Copy link
Owner

isaacs commented Mar 21, 2024

Hm, since it's defaulting in the recommended root tsconfig anyway, could probably just strike this line: https://github.com/isaacs/tshy/blob/main/src/tsconfig.ts#L53

For posterity if anyone comes searching and finds this issue, can you share what situation you're finding where it needs to be different?

@mpodwysocki
Copy link
Contributor Author

@isaacs For example, we shipped our new Azure SDK Core JavaScript libraries which were previously targeting ES2020/ES2017. Some of our customers complained once upgrading that their TypeScript version did not support particular syntax which were in ES2022 such as this issue: Azure/azure-sdk-for-js#28918

@isaacs
Copy link
Owner

isaacs commented Mar 21, 2024

Ahhh, yes, node 14. Cool, makes sense.

timovv added a commit to timovv/tshy that referenced this issue Mar 21, 2024
So that compilerOptions.target is pulled from the base tsconfig instead
Fixes isaacs#54
timovv added a commit to timovv/tshy that referenced this issue Mar 21, 2024
So that compilerOptions.target is pulled from the base tsconfig instead
Fixes isaacs#54
@isaacs
Copy link
Owner

isaacs commented Mar 28, 2024

Fixed by #55

@isaacs isaacs closed this as completed Mar 28, 2024
@isaacs
Copy link
Owner

isaacs commented Mar 29, 2024

1b4b73a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants