Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

audit feedback #216

Merged
merged 56 commits into from
Apr 26, 2024
Merged

audit feedback #216

merged 56 commits into from
Apr 26, 2024

Conversation

bekauz
Copy link
Collaborator

@bekauz bekauz commented Apr 23, 2024 •
edited
Loading

@bekauz
two party holder stores emergency committee address on instantiation
ee1f7b9
@bekauz
single party holder lockup config update assertions fix
c4db8cd
@bekauz
native router no longer reserves ntrn for gas
68758e6
@bekauz
interchain router distribute fallback expects sender to cover the ibc…
b49f3ff 
… fee
@bekauz
querying neutron ibc tx and ica registration fees on demand; removing…
3f3e7fe 
… all hardcoded IbcFee configurations
@bekauz
astro liquid pooler withdraw handles non-lp token withdrawal
eb12937
@bekauz
remote chain splitter routes any rounding leftover denoms to first sp…
035d4b7 
…lit receiver; removing duplicate denom validation on instantiation
@bekauz
two party holder validation for lockup expiration to be after the dep…
dbf9bd0 
…osit deadline
@bekauz
two party holder party host_addr and contribution amount validation
189907a
@bekauz
interchain router clock and destination receiver address validation
d1bff06
@bekauz
native splitter validates clock address on instantiation
5e102d6
@bekauz
swap holder party address validation; native receiver config returns …
545c83e 
…string address to be validated on destination contracts
@bekauz
astroport liquid pooler validates withdraw percentage range
de1c3cb
@bekauz
single party holder validates lockup config
7020619
@bekauz
validating split receiver addresses & shares in native and remote cha…
91e77aa 
…in splitters
@bekauz
top level covenant contract codes config migration
ae907d8
@bekauz
swap covenant ensures party contribution denom on neutron is explicit…
a00001a 
…ly defined in native splitter
@bekauz
setting withdraw state on single party holder emergency withdrawal
7efe675
@bekauz
swap covenant refunds parties by bank sending respective denoms to pr…
6eba1fd 
…econfigured addresses
@bekauz
using verify_clock to validate clock address in swap holder
5f41d28
@bekauz
two party holder migration split validation
6729805
@bekauz
swap and two party covenant conditional ibc forwarder instantiate2 co…
072d9c7 
…nfig derivation
@bekauz
two party holder dequeues on completion
36618bf
@bekauz
removing commented code blocks from native router and single party ho…
ee820ad 
…lder
@bekauz
removing debug messages
72711c8
@bekauz
removing todo!() macros
a561360
@bekauz
removing old tests
93d3265
@bekauz
removing unused deps; clippy; fmt
54233e9
@bekauz
removing remote chain splitter complete state; clearing INTERCHAIN_AC…
18c66e2 
…COUNTS storage on sudo timeout
@bekauz
removing ibc forwarder complete state
a1452af
bekauz and others added 22 commits March 19, 2024 21:29
@bekauz
soft remote chain address validation in interchain-router and remote-…
08d864a 
…chain-splitter
@bekauz
streamlining code duplicates from contracts that deal with icas
1e74556
@bekauz
moving ibc fee query and assertion to utils
30374dc
@bekauz
removing submsg events from astroport liquid pooler reply attributes
dffb4d2
@bekauz
two party POL holder refunds from Complete state
59b723d
@bekauz
swap holder indefinitely attempts party deposit refunds from expired …
b5a096b 
…state
@bekauz
astro liquid pooler errors out if either of expected pool asset balan…
55a03bd 
…ces is 0
@bekauz
single party holder withdrawer and withdraw_to fields no longer optional
574fa1f
@bekauz
adding astro liquid pooler xyk single side lp limits validation; all …
9f04b58 
…pool types error if single side limits validation fails
@bekauz
using common ica id across all ica-enabled contracts
4935764
@bekauz
adding osmo outpost migration entrypoint; add missing code id migrate…
e9ce3a3 
…msg variants to single & two party pol top level covenants
@stiiifff
Tweak ci action (#201)
e3fc870 
(cherry picked from commit f7758ed)
@bekauz @stiiifff
using decimal instead of uint64 for party allocation in 2p covenant i…
cac6109 
…nstantiate msg
@bekauz @stiiifff
pull CONTRACT_NAME from cargo via env!; adjust cargo package names
2adc5b2
@bekauz @stiiifff
osmo liquid pooler option to withdraw party denoms from proxy
af9a159
@bekauz @stiiifff
wip: interchaintest adjustments
f6c7386
@bekauz @stiiifff
osmo liquid pooler handles withdrawals via pending withdraw state
1b88a23
@bekauz @stiiifff
handling pre and post-proxy funding party denom withdraw cases in osm…
20099fe 
…o liquid pooler
@bekauz @stiiifff
revert pre & post-funding proxy withdraw branching
eeac611
@bekauz @stiiifff
adjust ictests to new instantiate msgs
570122e
@bekauz @stiiifff
ci fix
d8c60cc
@bekauz
extending e2e test execution limit to 60m
9363541
@bekauz bekauz requested a review from stiiifff April 26, 2024 10:12
stiiifff
stiiifff approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@stiiifff stiiifff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !!! 🚀

@bekauz bekauz merged commit 0093842 into v2 Apr 26, 2024
8 checks passed
@bekauz bekauz deleted the audit-fixes branch April 26, 2024 10:24
This was referenced Apr 26, 2024
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stiiifff stiiifff stiiifff approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bekauz @stiiifff