audit feedback

.github/workflows/basic.yml → .github/workflows/check.yml

@@ -1,75 +1,71 @@
-# Based on https://github.com/actions-rs/example/blob/master/.github/workflows/quickstart.yml
-on: [push, pull_request]
+name: Check Build and Tests
 
-name: Basic
+on:
+  push:
+    branches: [ main ]
+  pull_request:
 
-env:
-    RUST_BACKTRACE: 1
-    CARGO_TERM_COLOR: always
+  workflow_dispatch:
 
 jobs:
-  unit-test:
-    name: Test Suite
+  check:
     runs-on: ubuntu-latest
     steps:
       - name: checkout sources
         uses: actions/checkout@v3
 
-      - name: Install latest stable toolchain
+      - name: Install stable toolchain
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: 1.71.0
-          target: wasm32-unknown-unknown
+          toolchain: 1.76.0
           override: true
+          components: rustfmt, clippy
 
-      - name: Run tests
+      - name: Run cargo fmt
         uses: actions-rs/cargo@v1
         with:
-          command: test
-          args: --locked
+          command: fmt
+          args: --all -- --check
+
+      - name: Run cargo clippy
+        uses: actions-rs/cargo@v1
+        with:
+          command: clippy
+          args: --all-targets -- -D warnings
+
+      # - name: Generate Schema
+      #   run: ./scripts/schema.sh
+
+      # - name: Schema Changes
+      #   # fails if any changes not committed
+      #   run: git diff --exit-code schema
 
-  lints:
-    name: Lints
+  test:
     runs-on: ubuntu-latest
     steps:
-      - name: checkout sources
+      - name: Checkout sources
         uses: actions/checkout@v3
 
       - name: Install stable toolchain
         uses: actions-rs/toolchain@v1
         with:
           profile: minimal
-          toolchain: 1.71.0
+          toolchain: 1.76.0
+          target: wasm32-unknown-unknown
           override: true
-          components: rustfmt, clippy
-
-      - name: Run cargo fmt
+      - name: Run unit tests
         uses: actions-rs/cargo@v1
         with:
-          command: fmt
-          args: --all -- --check
+          command: test
+          args: --locked
+        env:
+          RUST_BACKTRACE: 1
 
-      - name: Run cargo clippy
+      - name: Compile WASM contract
         uses: actions-rs/cargo@v1
         with:
-          command: clippy
-          args: --all-targets -- -D warnings
-
-  # schema:
-  #   name: Schema
-  #   runs-on: ubuntu-latest
-  #   steps:
-  #     - name: Checkout sources
-  #       uses: actions/checkout@v2
-
-  #     - name: Install stable toolchain
-  #       uses: actions-rs/toolchain@v1
-  #       with:
-  #         profile: minimal
-  #         toolchain: 1.66.0
-  #         override: true
-  #         components: rustfmt, clippy
-
-  #     - name: Gen schemas
-  #       run: ./scripts/schema.sh
+          command: wasm
+          args: --locked
+        env:
+          RUSTFLAGS: "-C link-arg=-s"

.github/workflows/interchaintest.yml

@@ -129,8 +129,8 @@ jobs:
         uses: extractions/setup-just@v1
 
       - name: two party POL native & interchain parties
-        run: mkdir interchaintest/two-party-pol/wasms && cp -R artifacts/*.wasm interchaintest/two-party-pol/wasms && cp -R interchaintest/wasms/astroport/*.wasm interchaintest/two-party-pol/wasms && just local-e2e two-party-pol TestTwoPartyNativePartyPol
+        run: mkdir -p interchaintest/two-party-pol/wasms && cp -R artifacts/*.wasm interchaintest/two-party-pol/wasms && cp -R interchaintest/wasms/astroport/*.wasm interchaintest/two-party-pol/wasms && just local-e2e two-party-pol TestTwoPartyNativePartyPol
 
       - name: two party POL two interchain parties
-        run: mkdir interchaintest/two-party-pol/wasms && cp -R artifacts/*.wasm interchaintest/two-party-pol/wasms && cp -R interchaintest/wasms/astroport/*.wasm interchaintest/two-party-pol/wasms && just local-e2e two-party-pol TestTwoPartyPol
+        run: mkdir -p interchaintest/two-party-pol/wasms && cp -R artifacts/*.wasm interchaintest/two-party-pol/wasms && cp -R interchaintest/wasms/astroport/*.wasm interchaintest/two-party-pol/wasms && just local-e2e two-party-pol TestTwoPartyPol