-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Provide per-app screenshots for AppData #5
Comments
It is used to retrieve/change web view dimensions and to take a snapshot. Issue: tiliado/nuvolasdk#5
|
|
Hello @a-m-s, could you jump in? What are the minimum dimensions of the web view for your scripts? Please use the Web View sidebar from eu.tiliado.NuvolaAdk//master (that of stable suffers from a GTK+ bug and hangs). |
How about 1080×650?
Can be the player controls captured or do they fade away immediately? It's time to spin up my virtual machines and test following:
|
Well, 1280×720 is 16:9, not 1280×768 :-/
Which is the best width < 1080 px for 650 px height?
Fair point, use whathever screen is the most representative for the web app. Btw, I've added an optional delay to the snapshot tool. I think I will need it for YouTube. |
The website changes layout at 960px, so the "best" is 959x650. 1280x720 is fine too. |
It looks ok on white background, but in reality, there are semitransparent pixels! Need to read more Pillow doc. |
It automatically detects `src/webview.png` file and creates screenshots in the `screenshots` directory. Issue: #5
Hello @a-m-s, could you try that with your script? Save a screenshot as The base screenshots are not final (e.g. the Unity one has a scrollbar that should be removed eventually), but they are good enough for testing. |
It will say "Nuvola Player" or something like that in the final base screenshot. I've been working on a player demo script to be used to create base screen shots. |
Do I need to do anything else now? |
You can commit the web view snapshots. I'll then use them when the final base screenshots are ready. |
→ #8 |
- Issue: tiliado/nuvolaplayer#420 - Issue: tiliado/nuvolasdk#5 Signed-off-by: Jiří Janoušek <[email protected]>
🎉 All scripts have a web view screenshot. |
Issue: #5 Signed-off-by: Jiří Janoušek <[email protected]>
New base screenshots show "Nuvola Player" instead of "Deezer". |
|
Issue: #5 Signed-off-by: Jiří Janoušek <[email protected]>
Issue: tiliado/nuvolasdk#5 Signed-off-by: Jiří Janoušek <[email protected]>
Blocked by: #8Currently, Nuvola uses screenshots of Deezer for all scripts, which is weird at least, e.g. you look for "Spotify" in GNOME Software and it shows an app with the screenshots of Deezer.
Since I cannot expect from script maintainers to create and periodically update their screenshots with Nuvola's desktop integration features, it would be better to create generic screenshots of the features and then replace the generic web view with a screenshot of the actual web view of a particular app.
First, it is necessary to agree on the dimensions of the web view screenshots that are suitable for most apps. Nuvola should provide a Web View sidebar as a part of developer's tools. The sidebar will be used to retrieve current dimensions as well as to resize the web view to dimensions entered by the developer.
Each maintainer should provide the minimal size when all playback controls are visible and the web page is usable, i.e., there is no clipping of the web page and no important elements are hidden behind a scrollbar.
Once we agree on the dimensions, the maintainers will use the Web View sidebar to set the dimensions, take a snapshot of the web view and save it as
src/webview.png
.Nuvola SDK will combine the base screenshot and the web view snapshot into a final screenshot, which will be hosted on https://nuvola.tiliado.eu and referenced in AppData XML.
Script maintainer may reference the screenshots in README.md.
Tasks:
The text was updated successfully, but these errors were encountered: