Toggle repeat on/off

[jiri-janousek]

Integrate player action toggle repeat on/off

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

[jiri-janousek]

Hello @a-m-s, @bors-ltd, and @d-r-q. Could you integrate the repeat status if it is relevant to your scripts? You need up-to-date Nuvola ADK >= 4.12.86. Also, don't forget to raise api_major/api_minor in metadata.in.json to 4/13. Thanks!

[a-m-s]

Amazon Music is done. The others don't have a repeat feature.

[d-r-q]

Yandex.Music don't support repeat

[jiri-janousek]

Amazon Music is done. The others don't have a repeat feature.

Thanks :-) I've added a few inline comments to address: tiliado/nuvola-app-amazon-cloud-player@74fa997

[jiri-janousek]

Yandex.Music don't support repeat

Hello @d-r-q. There seems to be a repeat button in the bottom right corner (next to the volume button) on your screenshot. Was it removed? Or what's its functionality?

[d-r-q]

Oh, I'm blind... Integrate it later this week.

[jiri-janousek]

Currently completed repeat integrations will be announced on Sunday, September 23rd. The rest with Nuvola 4.13.0 (#472) or later when implemented.

[d-r-q]

Hi @fenryxo, I've added support for repeat (and shuffle), but I'm little confused with current release process. Should I create an issue and/or pull request for this changes? And should I update changelog file?

[bors-ltd]

Added both repeat a track and the whole playlist to Qobuz.

Updated the changelog, ready for release.

I forgot to mention this on the shuffle issue but for some reason, the functions setCanShuffle and setCanRepeat were not available, though I used what I think is the latest SDK 4.12.92. So I used the "low-level" ones from the first announce. It won't make a difference for users.

[jiri-janousek]

I've added support for repeat (and shuffle), but I'm little confused with current release process. Should I create an issue and/or pull request for this changes? And should I update changelog file?

Hello @d-r-q. The current release process needs to be documented, because the one in docs predates the switch to Flatpak builds. It works roughly this way:

• Always update the changelog, but don't touch version numbers in metadata.in.json.
• If you wish to have a code review, create a pull request to the master branch.
• If you don't need a code review, commit directly to the master branch (@a-m-s does that).
• Whatever is in the master branch is included in the next rebuild of Flatpaks.
• Once for a while, I make a new X.Y.0 release of Nuvola and all components for third-party packagers. That's when the version_minor field gets updated.

[jiri-janousek]

Added both repeat a track and the whole playlist to Qobuz.

Updated the changelog, ready for release.

Great, I rebuilt Qobuz flatpak today in the morning so your changes are live :-)

I forgot to mention this on the shuffle issue but for some reason, the functions setCanShuffle and setCanRepeat were not available, though I used what I think is the latest SDK 4.12.92. So I used the "low-level" ones from the first announce. It won't make a difference for users.

That's strange. Are you sure that nuvolaruntime --version said 4.12.92? If you are in a Bash session of Nuvola ADK and you update the ADK flatpak, the old flatpak is still in use until all its instances exit. (This way, it won't happen that a running flatpaked app crashes because its data files have suddenly changed because of a pending update.)

[jiri-janousek]

• Most scripts announced in Update 10: Nuvola Integrates Repeat & Shuffle Status, Adjusts to New Deezer Design, And More
• Yandex Music (Support for shuffle and repeat nuvola-app-yandex-music#17) will be announced with Nuvola 4.13.0 (Release Nuvola 4.13 #472).

[bors-ltd]

Here is the output:

$ nuvola-adk
bash-4.3$ nuvolaruntime --version
Qobuz script
Version: 1.1.3
Revision: 3-gca69c9a
Maintainer: Bors, Ltd

--- Powered by ---

Nuvola Apps - Genuine flatpak build
Version 4.12.92
Revision 92-gbe08264
Diorite 4.12.24
WebKitGTK 2.20.2
Chromium 68.0.3440.75
libsoup 2.62.1

I'm sure no ADK session was open when I updated. I'll try again when updating to 4.13.0.

[jiri-janousek]

Hello @bors-ltd, could you check whether your issue persists with Nuvola ADK 4.13.0? If yes, please create a new ticket for that. Thanks.

[jiri-janousek]

Released in Nuvola 4.13.0.