This repository has been archived by the owner on Apr 4, 2019. It is now read-only.
[Bugfix] fix props first logic #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
stefanpenner
commented
Jul 3, 2015
stefanpenner
commented
- for exceptions input.form, input.list, button.type always use setAttributes
- for form.action always escape
- always assign handlers to props, even if the case appears strange
- refactor normalizeProperty to return an object that clearly indicates type: & normalized:
|
|
This was referenced Jul 3, 2015
Closed
|
LGTM. Thanks for the effort on this tricky bit @stefanpenner! |
|
(Should be |
|
@wycats wanted to sync on this this afternoon. |
* for exceptions input.form, input.list, button.type always use setAttributes * for form.action always escape * always assign handlers to props, even if the case appears strange * refactor normalizeProperty to return an object that clearly indicates type: & normalized:
|
@mixonic updated |
|
oh well, #yolo |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.