-
Notifications
You must be signed in to change notification settings - Fork 193
[BUGFIX] Adds the ability to blacklist props that should use setAttribute because of browser compliance issues #355
Conversation
ef08002
to
d4cef98
Compare
Added another test. |
d4cef98
to
2d81613
Compare
2d81613
to
43952de
Compare
Amended with |
Seems good to me. @mixonic can you review and 👍 / 👎? |
…bute because of browser compliance issues, fixes emberjs/ember.js#11112
43952de
to
120869a
Compare
@mixonic ping |
we should add the form attribute for the appropriate tags aswell. Essentially merging this PR and https://github.com/tildeio/htmlbars/pull/352/files |
Seems fine. |
@stefanpenner I would prefer #353 since it covers more than just the form attribute case. I plan to rebase once this is merged. Thoughts? |
@jayphelps yes i believe so, although i don't believe it handles the |
@stefanpenner It does not. Sorry if this is confusing. This PR handles specific cases of |
@stefanpenner Although we could use this PR's blacklist method for |
[BUGFIX] Adds the ability to blacklist props that should use setAttribute because of browser compliance issues
fixes emberjs/ember.js#11112 and sets the stage for #353 which is the same code-path and desired outcome but different cause.