Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Button type is not submit in phantomJS for some odd reason #50

Closed
toranb opened this issue Jun 15, 2015 · 2 comments
Closed

Button type is not submit in phantomJS for some odd reason #50

toranb opened this issue Jun 15, 2015 · 2 comments

Comments

@toranb
Copy link

toranb commented Jun 15, 2015

I've found that phantomJS doesn't seem to respect the line below (making the type of the button truly submit). Is this a known issue/ does a workaround or explanation exist anywhere that I could read up on this? Mostly curious why chrome generates the correct html and phantom 1.9.16 doesn't

https://github.com/dockyard/ember-cli-async-button/blob/master/addon/components/async-button.js#L17

Thanks again for maintaining such a great OSS project !

@toranb
Copy link
Author

toranb commented Jun 15, 2015

Looks like I found the answer to both this and the comment I put in PR #46

tildeio/htmlbars#353 (comment)

@jayphelps
Copy link

Actually, that PR (while touching the same code path) is for a different issue, albeit similar. <button> type issue was reported here emberjs/ember.js#11112 and fixed here tildeio/htmlbars#355

@courajs courajs closed this as completed Nov 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants